world.internet_address implementation
#2017
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ike709
changed the title
world.internet_address as implementedworld.internet_address implementation
wixoaGit
requested changes
Oct 6, 2024
| @@ -58,7 +58,7 @@ private bool DisplayIPv6 { | |||
| } | |||
|
|
|||
| /// <summary> Tries to return the address of the server, as it appears over the internet. May return null.</summary> | |||
| private IPAddress? InternetAddress => null; //TODO: Implement this! | |||
| private IPAddress? InternetAddress => _netManager.ServerChannel?.RemoteEndPoint.Address ?? null; | |||
There was a problem hiding this comment.
I think this only tells you the local address this server is bound to, not the external IP others will have to use to connect.
I don't know if RT has a way to get this currently.
|
rip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #191