Fix atom name/desc not copying on appearance set #2145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
Client
amylizzle
suggested changes
Dec 18, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -38,6 +31,12 @@ | |||
|
|
|||
| base.HandleDeletion(possiblyThreaded); | |||
| } | |||
| public string GetDesc() { | |||
Check warning
Code scanning / InspectCode
Incorrect blank lines: Blank lines are missing elsewhere Warning
| @@ -38,6 +31,12 @@ | |||
|
|
|||
| base.HandleDeletion(possiblyThreaded); | |||
| } | |||
| public string GetDesc() { | |||
| if (!TryGetVariable("desc", out DreamValue descVar) || !descVar.TryGetValueAsString(out string? desc)) | |||
| return ObjectDefinition.Type.ToString(); | |||
Check warning
Code scanning / InspectCode
Redundant 'object.ToString()' call Warning
wixoaGit
requested changes
Dec 18, 2024
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2107 by adding a desc var to appearances and changing atom var access methods to always defer to appearance.
There's a warning on the
IconAppearanceclass that begins "Woe, weary traveler" so hopefully I've done all the steps right to avoid doom or whatever.Includes a DM test to hopefully prove it works.