Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thing.appearance = otherthing.appearance doesn't copy name and desc #2107

Open
amylizzle opened this issue Nov 21, 2024 · 0 comments · May be fixed by #2145
Open

thing.appearance = otherthing.appearance doesn't copy name and desc #2107

amylizzle opened this issue Nov 21, 2024 · 0 comments · May be fixed by #2145
Labels
Runtime Involves the OpenDream server/runtime

Comments

@amylizzle
Copy link
Contributor

/obj/thingtocopy
    name = "hello"
    desc = "this is a thing"

/proc/test()
    var/obj/thingtocopy/T = new()
    var/obj/otherthing = new()
    otherthing.appearance = T.appearance
    ASSERT(otherthing.name == T.name)
    ASSERT(otherthing.desc == T.desc)

There's probably some other things that are copied in appearance assignments like this that we've missed too.

@wixoaGit wixoaGit added the Runtime Involves the OpenDream server/runtime label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Runtime Involves the OpenDream server/runtime
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants