Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refact some files #114

Merged
merged 13 commits into from
Sep 23, 2019
Merged

Refact some files #114

merged 13 commits into from
Sep 23, 2019

Conversation

fanny
Copy link
Contributor

@fanny fanny commented Aug 2, 2019

Summary

  1. Improvement of semantic html
    In many places, divs was used, but with html5 generally there is a tag for specific purpose.
    I added the following tags:
  • main - represents the dominant content of the of a document.
  • footer - represents a footer for its nearest sectioning content or sectioning root element.
  • section - represents a standalone section — which doesn't have a more specific semantic element to represent it — contained within an HTML document.
  • aside - represents a portion of a document whose content is only indirectly related to the document's main content.
  • figure - specifies self-contained content, like illustrations, diagrams, photos, code listings, etc.
  • figcaption - represents a caption or legend describing the rest of the contents of its parent element.

Mozilla HTML elements reference

  1. Improve Icon package
    The icons, current, is in separate packages, but as they shared "same logic", imo, they should be in the same package

  2. Fix react hot reload
    I added the react-hot-reload dependency, before this change, live-reload wepback-dev-server didn't work for react components.

  3. Improvement of first page css
    In the Footer.css file, elements are positioned by padding prop. Instead, I change the footer to occupy the final 14% of the screen and I use the placed-content and placed-items properties

TODO:

@fanny fanny marked this pull request as ready for review August 2, 2019 16:55
@fanny fanny self-assigned this Aug 2, 2019
@fanny fanny added Aprimoramento Nova feature ou solicitação de melhora Frontend Relacionado à Frontend Refatoramento Essa Issue ou esse Pull Request se refere a um refatoramento labels Aug 2, 2019
@fanny fanny requested a review from a team August 2, 2019 16:56
pedroespindula
pedroespindula previously approved these changes Aug 2, 2019
@pedroespindula pedroespindula requested a review from a team August 4, 2019 20:16
src/components/app/App.css Outdated Show resolved Hide resolved
src/components/app/App.js Outdated Show resolved Hide resolved
src/components/glossary/GlossaryPage.js Show resolved Hide resolved
@fanny
Copy link
Contributor Author

fanny commented Sep 23, 2019

Can we merge?

@fanny fanny merged commit a474103 into master Sep 23, 2019
@fanny fanny deleted the refact/some-files branch September 23, 2019 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aprimoramento Nova feature ou solicitação de melhora Frontend Relacionado à Frontend Refatoramento Essa Issue ou esse Pull Request se refere a um refatoramento
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Funcionalidade do botão de pesquisa
3 participants