-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refact some files #114
Merged
Merged
Refact some files #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanny
added
Aprimoramento
Nova feature ou solicitação de melhora
Frontend
Relacionado à Frontend
Refatoramento
Essa Issue ou esse Pull Request se refere a um refatoramento
labels
Aug 2, 2019
pedroespindula
previously approved these changes
Aug 2, 2019
thayannevls
suggested changes
Aug 5, 2019
thayannevls
approved these changes
Sep 23, 2019
Can we merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Aprimoramento
Nova feature ou solicitação de melhora
Frontend
Relacionado à Frontend
Refatoramento
Essa Issue ou esse Pull Request se refere a um refatoramento
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In many places,
divs
was used, but with html5 generally there is a tag for specific purpose.I added the following tags:
Mozilla HTML elements reference
Improve Icon package
The icons, current, is in separate packages, but as they shared "same logic", imo, they should be in the same package
Fix react hot reload
I added the
react-hot-reload
dependency, before this change, live-reload wepback-dev-server didn't work for react components.Improvement of first page css
In the
Footer.css
file, elements are positioned by padding prop. Instead, I change the footer to occupy the final 14% of the screen and I use theplaced-content
andplaced-items
propertiesTODO:
react hooks
(i'll open a discussion soonest)