Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structured data for attemptType #411

Open
3 tasks
CocoisBuggy opened this issue Nov 10, 2024 · 5 comments
Open
3 tasks

Structured data for attemptType #411

CocoisBuggy opened this issue Nov 10, 2024 · 5 comments

Comments

@CocoisBuggy
Copy link
Contributor

There has been some confusion about what data exactly to put in this field, and it would benefit us in the long-run to constrain this field for data aggregation purposes.

  • Add an enumeration with reasonable attemptTypes
  • Allow for some array of these attemptTypes to be assigned to a given tick - There is some philosophizing to be done on this point, but realistically you can have some of these types happen in conjunction.
  • Allow fetching of the enum from the database - This will be a changing set, so we shouldn't hard-code values accross the various services.
@Vichy97
Copy link
Collaborator

Vichy97 commented Nov 11, 2024

This should also apply to tick styles. Both should be an enum

@julianlam
Copy link

julianlam commented Nov 12, 2024

For what it's worth, a tick style doesn't seem to be relevant in a bouldering context. The field should be hidden in front-end, and if not already done so, the backend should allow null as an acceptable value (related; #419)

There are additional restrictions one can add (e.g. does the submitted style and attempt type combination make sense?), so things like Boulder/Pinkpoint are not allowed, but I think that might be overkill.

@vnugent
Copy link
Contributor

vnugent commented Nov 30, 2024

Copying @Vichy97 comment from Discord

style: only applicable to roped climbs.
Possible values:

  • solo
  • tr
  • follow
  • lead

attempt: Only applicable to boulders or roped climbs with "lead" style
Possible values for roped climbs

  • attempt
  • redpoint
  • pinkpoint
  • flash
  • onsight

Possible values for boulders

  • attempt
  • send
  • flash

anything that does not fall into these categories should throw an error

--

  • Question: For roped climbs is attempt the same as hangdogging?
  • Todo: we need to support style field

@Vichy97
Copy link
Collaborator

Vichy97 commented Nov 30, 2024

Ya I think attempt can represent Hung/Fell. The client can display this differently than it is recorded in the backend. Also we do have a style field, it just doesn't get imported from MP correctly

@vnugent
Copy link
Contributor

vnugent commented Dec 4, 2024

For lead style should we make it clear whether it's a free attempt or it's aid/french-free

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants