Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: topo data API #389

Open
btmccord opened this issue Feb 6, 2024 · 6 comments
Open

feat: topo data API #389

btmccord opened this issue Feb 6, 2024 · 6 comments
Assignees

Comments

@btmccord
Copy link

btmccord commented Feb 6, 2024

We need the ability to to assign and retrieve a JSON object to photos/photo tags for the topo feature

@btmccord btmccord changed the title feat: Assign and access topo data feat: topo data API Feb 6, 2024
@vnugent
Copy link
Contributor

vnugent commented Feb 7, 2024

Do you have some sample data so that we can figure out how to store/retrieve it in the backend?

@btmccord
Copy link
Author

btmccord commented Feb 7, 2024

Yep. Here you go

testdata.json

@btmccord
Copy link
Author

btmccord commented Feb 7, 2024

I would think we can just store it as a string. The paper import function works with a string and the export function returns a JSON object or string. See http://paperjs.org/reference/path/#exportjson

@vnugent
Copy link
Contributor

vnugent commented Feb 9, 2024

do you expect the internal structure to change? Another word should we store a version number along with the data?

@btmccord
Copy link
Author

btmccord commented Feb 9, 2024

I think its likely to change structure, especially as we implement new features. A version number seems like a good idea. Although the version could also be put into the topo data itself, which might be better?

@vnugent
Copy link
Contributor

vnugent commented Feb 10, 2024

Sure. We can make it an internal field for now. The version can help the frontend rendering code differentiate changes.

@vnugent vnugent self-assigned this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants