From dfab97e847cf92c9dac1316dcff929e394790ab2 Mon Sep 17 00:00:00 2001 From: Iacami Gevaerd Date: Sun, 10 Dec 2023 11:49:48 -0300 Subject: [PATCH] build: always build dockerfile but skip pushing if PR --- .github/workflows/nodejs.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 93b8f37a..0ed7faa9 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -67,7 +67,6 @@ jobs: # build docker image and push to registry docker: runs-on: ubuntu-22.04 - if: github.event_name != 'pull_request' needs: test steps: - name: 'Checkout Project' @@ -93,7 +92,6 @@ jobs: tags: | type=ref,event=branch type=semver,pattern={{raw}} - type=ref,event=pr type=sha,format=long - name: Build docker image @@ -102,7 +100,7 @@ jobs: context: ./ file: ./Dockerfile builder: ${{ steps.buildx.outputs.name }} - push: true + push: ${{ github.event_name != 'pull_request' }} tags: ${{ steps.meta.outputs.tags }} # setup basic machine to run all kinds of tests: lint, unit, integration, types