Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content width should be consistent from top to bottom of the page #1096

Closed
heliodor opened this issue Feb 13, 2024 · 4 comments
Closed

Content width should be consistent from top to bottom of the page #1096

heliodor opened this issue Feb 13, 2024 · 4 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@heliodor
Copy link

heliodor commented Feb 13, 2024

In the screenshot below, you can see the header is narrower than the rest of the page, and the banner and the map are full width. So there are three distinct widths to the content.

At the very least, the header should match the fixed max width of the content.

The full-width map can be excused as making full use of the space I suppose. Why not do the same with the pictures and use the full width?

Anyway, it's probably best to have a max width and stick to it. It will make the html/css simpler too.

Screenshot 2024-02-13 at 10 19 53 AM

@btmccord
Copy link
Contributor

I think the map should stay full width, but I agree the other content should maintain a standard with.

@btmccord btmccord added good first issue Good for newcomers help wanted Extra attention is needed labels Feb 26, 2024
@vnugent vnugent self-assigned this Mar 26, 2024
@vnugent
Copy link
Contributor

vnugent commented Mar 26, 2024

fixed in #1116

@vnugent vnugent closed this as completed Mar 26, 2024
@vnugent vnugent moved this from General backlog to Done in OpenBeta Project board Mar 26, 2024
@github-project-automation github-project-automation bot moved this to General backlog in OpenBeta Project board Mar 26, 2024
@heliodor
Copy link
Author

heliodor commented Mar 27, 2024

What I meant: content width should be consistent across all pages!

In other words, there should be a template skeleton page from which all pages are rendered by filling in the "container" for the content. Things this template skeleton page should include:
header
footer
content container (full width, fixed width, whatever you like, but pick one)
a sidebar of some sort, if desired

@vnugent
Copy link
Contributor

vnugent commented Jun 7, 2024

@heliodor I updated the landing page layout. Except for individual climb pages and user profile, all other pages now use the same layout and margins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
Development

No branches or pull requests

3 participants