Improvement: Create new message handler for inbound/outbound messages to support RabbitMQ/others #88

[igwtech]

This plugin allows OpenAS2 to interconnect with a Message Queue Broker (i.e RabbitMQ) for message exchange and message tracking events.

[uhurusurfa]

Why are you re-implementing the MessageBuilderModule?
If there is something that you need in the existing one then lets talk about enhancing it rather than duplicating all the code.

[igwtech]

The original uses the filename to get the partnership info and other metadata. MQ messages have the headers for that purpose. That's was basically the difference. J

…

On Sat, Nov 16, 2019, 10:14 AM Christopher Broderick < ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In Plugins-MQ/src/main/java/com/greicodex/openas2/plugins/mq/MessageBuilderModule.java <#175 (comment)>: > +public abstract class MessageBuilderModule extends BaseReceiverModule { + Why are you re-implementing the MessageBuilderModule? If there is something that you need in the existing one then lets talk about enhancing it rather than duplicating all the code. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#175?email_source=notifications&email_token=AA2QND7R75EMOPMH5CNFZ2TQT755FA5CNFSM4JN7TLL2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLZ6AEY#pullrequestreview-317972499>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA2QND2GTWA73IYPWML634DQT755FANCNFSM4JN7TLLQ> .

[uhurusurfa]

Ok - lets make the retrieval of that info into a method in MessageBuilderModule then it can be overridden by modules that need something diffferenmt if necessary or simply pass additional parameters in the AS2Message context object to.
Break MessageBuilder down into smaller methods that can be overridden wherever necessary.