Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more colors in textual output #2500

Open
ReimarBauer opened this issue Sep 2, 2024 · 3 comments · May be fixed by #2594
Open

more colors in textual output #2500

ReimarBauer opened this issue Sep 2, 2024 · 3 comments · May be fixed by #2594

Comments

@ReimarBauer
Copy link
Member

There is a red warning and 3 white Warning, and the Info Text is orange

image

I think we should have all warnings in the same color, different to info but not white, as in this example

@anshulagrawal2902
Copy link

I agree with you, I also noticed that the RED warning is actually an INFO statement from the application's point of view. I am interested in taking a look, could you assign this issue to me ?

@anshulagrawal2902
Copy link

anshulagrawal2902 commented Dec 28, 2024

I was looking into this and I don't understand why are we not using a singleton logger instance. I saw definition for the setup_logger function, but we rarely use it. Most modules have an import logging statement and they are using the root logger. This makes it difficult to make changes like the one in this issue. Either I misunderstood it or I am lacking context. Regardless, I would appreciate your view on the problem.

@ReimarBauer
Copy link
Member Author

The whole thing has simply grown over 10 years and currently most of the tasks for MSS are to refactor it and increase stability.
We have to make sure that we can e.g. suppress the matplotlib logger and output all our logging messages. That is much easier by a singleton and logging definitions so that different users can use their own.

@anshulagrawal2902 anshulagrawal2902 linked a pull request Dec 31, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants