-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: LinearView and SideView plot to display operation name #2592
Conversation
Hi @TheMightyRaider this is partly done. it is a good step. We can have opened views while we can change the flight or operation.
look into the seed module for credetentials When we change the model we need also to update this entry on the plot. This is missing yet in the solution. Have a look into viewwindows.setFlightTrackModel how it is done for the window title |
Thank you @ReimarBauer for your feedback, Will fix the issues mentioned! |
@ReimarBauer , Pushed a commit with the review changes you had mentioned! Let me know if it looks good on your end! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that @ReimarBauer , Thanks for your feedback once again.
screen-recording-2024-12-30-at-92354-pm_ZbXrvfJf.mp4 |
On the place where EPSG was printed there where also optional airdata credentionals on topview shown. The place was for EPSG and that good. Or how does this look now when you select that in the docking widget? (Select to open control) |
On the place where EPSG was printed there where also optional airdata credentionals on topview shown. The place was for EPSG and that was quite good. Or how does this look now when you select that in the docking widget? For comparing with underlaying data. Click Server/Layer and add a Server url. E.g. http://open-mss.org (not https) Then select a layer. The model name should be on the plot too. |
@ReimarBauer When the size of the window is small, The text gets crowded. |
The name is mostly needed on a saved plot / printed plot. On screen having it at the window title is ok. |
I tried putting the title in the bottom left. But now it overlap with the x-axis values during sideview plot. |
ideas are welcome to improve matplotlib/qt visualizations. |
@ReimarBauer, I'm not sure whether I got right. Do you mean to say, we keep the model name alone at the top right for all the three views [ side, top and linear ] ? |
@TheMightyRaider yes we should have same place for the model name on all three views. Currently at the top right is the best option. The special information EPSG, etc on TopView should be kept on its origin place. |
@ReimarBauer, Pushed the changes! |
On github is a rule for the CI it did not start for new contributors automatically. I cannot change that. The tests can ran locally, e.g. https://github.com/Open-MSS/MSS/blob/develop/.github/workflows/testing.yml#L68, https://github.com/Open-MSS/MSS/blob/develop/.github/workflows/lint.yml#L69 |
@TheMightyRaider look on the flake8 linter, meanwhile I play with the changes |
b661fef
to
33215cb
Compare
@ReimarBauer , Fixed the linting issues thrown by flake8. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TheMightyRaider have you seen the opportunity to refactor the sigature of update_info_text ? |
@ReimarBauer , Nice find! I have updated the Quoting below your earlier comment,
I don't understand what you meant by API here? |
We have not defined a public Application Programming Interface. That means any signature change is also an API change. |
Ahh okay! Thanks for the clarification! |
https://github.com/Open-MSS/MSS/blob/develop/.github/workflows/testing-all-oses.yml, This workflow is failing if I'm not wrong. 😢 |
If it is because of timeout or mac tests that is not related to your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, for solving this
Thank you for your guidance! @ReimarBauer |
Purpose of PR?:
To show operation name in the sideview and linearview plot area.
Fixes #2461
Does this PR introduce a breaking change?
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Does this PR results in some Documentation changes?
If yes, include the list of Documentation changes
Checklist:
<type>: <subject>