Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

security risk: traceback_with_variables #939

Open
soxofaan opened this issue Nov 14, 2024 · 1 comment
Open

security risk: traceback_with_variables #939

soxofaan opened this issue Nov 14, 2024 · 1 comment

Comments

@soxofaan
Copy link
Member

@JeroenVerstraelen you originally added this traceback_with_variables feature here:

openeo-geopyspark-driver/openeogeotrellis/deploy/batch_job.py

Line 746 in 5e0f8cb

logger.info("Batch job error stack trace with locals", extra={"exc_info_with_locals": format_exc(e, fmt=fmt)})

But I've noticed that this exposes access keys in the (batch job) logs. It seems quite risky to blindly expose all local vars in our logs.

Do we still need or use this feature?
soxofaan added a commit that referenced this issue Nov 14, 2024
@soxofaan
Issue #939 disable exc_info_with_locals logging for now
7a507dd 
This is quickfix that need future fine-tuning (or complete removal)

Also avoid importing generic symbols like "Format" in global namespace
@soxofaan
Copy link
Member Author

I already quickfixed this by disabling it for now in 7a507dd

maybe we should only enable this on dev deploys?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@soxofaan