Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions for extra tests for wiki harvesting #88

Open
hyanwong opened this issue Jul 8, 2024 · 3 comments
Open

Suggestions for extra tests for wiki harvesting #88

hyanwong opened this issue Jul 8, 2024 · 3 comments

Comments

@hyanwong
Copy link
Member

hyanwong commented Jul 8, 2024

I'll have a go at adding these:

  1. Tests which are not normally run, as they require online access
    a. Check that definitions in _OZglobals.py (e.g. wikiflags and src_flags) match the versions in the same file in the latest OZtree repo
    b. get -- real-apis to work (see Tests partially broken when using --real-apis #71, and find the best way to implement something similar for tests in the TestAPI class)

  2. Check process_clade (see Not testing process_clade #72 )

  3. Check crop positioning (manual setting and also that the mocked Azure crop successfully returns the correct portion of the image.

@davidebbo
Copy link
Collaborator

The "get --real-apis to work" part is done, as of 08b9233. Please check that you can run it without errors.

@hyanwong
Copy link
Member Author

hyanwong commented Jul 8, 2024

Thanks. I presume it might be useful to figure out how to get --real-apis to work with the tests in the testAPI class? AT the moment the tests are only done for the full pipeline (i.e. TestCLI). But perhaps that's enough anyway?

@davidebbo
Copy link
Collaborator

My take is that full pipeline is sufficient, and most represents what we actually run in real use. Of course, more tests is always better, but in this case I think there is diminishing return.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants