-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unique canonical name per connector #38
Comments
Note that the separator character chosen may appear in a connector or pin name (so far I've seen |
This should be sufficient to create the desired canonical name (sans board name): connector.userData.drill = drills[ i ];
if ( drills[ i ].elementParent ) {
+ connector.name = drills[ i ].elementParent.getAttribute("name") + "." + drills[ i ].getAttribute("name");
connector.userData.element = drills[ i ].elementParent;
} produces a name like so:
Will work on patching the library with this now. |
The generated names can be viewed in the console via:
(Note that every second connector has no name, as they're the bottom-side connectors.) (I looked into demoing with a tool-tip for each hole but as there seems to be no standard Three.js tool-tip implementation I've just stuck with the console demo for now.) |
Initially can be of the form
<board?>.<connector>.<pin>
but since it's desired to expose this as a JS property it may need to changed/exposed as<connector>_<pin>
,<Connector><Pin>
or similar.The text was updated successfully, but these errors were encountered: