-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle !xx
/!xx!
inverted signal label display convention
#11
Comments
It appears the code that handles this is in We'll need to parse the label/legend text to determine which characters need the bar/line over them. Apparently this is generically called an Overline and can be implemented with CSS using |
The Unfortunately the And it seems like only the (Another option might be to hack something with the (As a side note, |
I hacked together a quick test using the For some reason the overlined text seems to result in use of a completely different (and narrower) font. (I changed the labels so the difference can be seen between "WP" with an overline and without.) No idea why this occurs... The overline seems pretty thin so we might be better to draw it ourselves anyway... Due to the font oddness there doesn't seem to be a clear "winner" in implementation at this stage. |
i'd run with that implementation and note that it's a suboptimal fix. create a new issue to look into fonts in a later round of work. |
Currently the library does not display labels using the
!xx
or!xx!
convention with the specified bar above the label.Example of current display:
Photo of actual board with correct display:
The text was updated successfully, but these errors were encountered: