Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Allow subject argument to olink_one_non_parametric_posthoc when using Friedman's test #478

Closed
sulealtintas opened this issue Nov 20, 2024 · 0 comments · Fixed by #485
Assignees
Labels
enhancement New feature or request

Comments

@sulealtintas
Copy link

Is your feature request related to a problem? Please describe.
It is unclear whether samples from the same subject are paired correctly in the post-hoc test for Friedman's test, as olink_one_non_parametric_posthoc does not take a subject argument. I found an old issue #161 on this, but it seems to have been marked completed without resolution.

Describe the solution you'd like
It should be possible to provide an argument subject specifying the column with the subject IDs to olink_one_non_parametric_posthoc, similarly to when calling olink_one_non_parametric. The data should then be sorted according to subject before the call to rstatix::wilcox_test with paired = TRUE, which assumes ordered data when pairing the data points.

Additional context
Example illustrating the importance of sample ordering in paired rstatix::wilcoxon_test: https://stackoverflow.com/a/78213490

@sulealtintas sulealtintas added the enhancement New feature or request label Nov 20, 2024
@boxizhang boxizhang mentioned this issue Nov 21, 2024
11 tasks
@kathy-nevola kathy-nevola linked a pull request Jan 16, 2025 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants