Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add match as a subclass of event #148

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

Olen
Copy link

@Olen Olen commented Oct 29, 2024

Should fix Olen/Spond#112

Not tested, just getting it out of the way for now

@elliot-100 elliot-100 linked an issue Dec 27, 2024 that may be closed by this pull request
@elliot-100
Copy link
Owner

Thanks @Olen.

I have added tests based on your example in Olen/Spond#112.

I think the output from Match.__str__ could perhaps be improved. At the moment it is very similar to an Event, e.g:
Match(uid='M1', heading='Match One', start_time: 2021-07-06 06:00:00+00:00, …)

I would think match_info.opponent_name and maybe match_info.team_name and match_info.type should be in there.

But I don't know what heading looks like for a real match.

@Bart274
Copy link

Bart274 commented Dec 28, 2024

Looks good

@elliot-100
Copy link
Owner

@Olen or @Bart274 do you know if any of these fields aren't always present? e.g. scores for a future match.

If so they should be optional on Match creation.

@elliot-100
Copy link
Owner

I've tested with a minimal future match and works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: add support for matches Add support for matches
3 participants