From c4d3ac0e7a425610384ca05886c286d8b5e1264b Mon Sep 17 00:00:00 2001 From: Matt Carter <96356887+0xDegenDeveloper@users.noreply.github.com> Date: Mon, 7 Oct 2024 15:53:39 -0400 Subject: [PATCH] comments --- .../option_round/state_transition/fulfill_request_tests.cairo | 2 ++ src/vault/contract.cairo | 4 ---- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/tests/option_round/state_transition/fulfill_request_tests.cairo b/src/tests/option_round/state_transition/fulfill_request_tests.cairo index cd499c7e..b8b487ef 100644 --- a/src/tests/option_round/state_transition/fulfill_request_tests.cairo +++ b/src/tests/option_round/state_transition/fulfill_request_tests.cairo @@ -180,3 +180,5 @@ fn test_fulfilling_multiple_request() { } } +// @note todo add test for request timestamp out of bounds (high and low for both fulfillment types (auction start/round settle)) +// @note todo add test for setting default values then starting auction/settling round diff --git a/src/vault/contract.cairo b/src/vault/contract.cairo index f4649e66..566a44fa 100644 --- a/src/vault/contract.cairo +++ b/src/vault/contract.cairo @@ -591,10 +591,6 @@ mod Vault { // address to fulfill requests, eventually update to proof verification instead let caller = get_caller_address(); assert(self.fulfillment_whitelist.entry(caller).read(), Errors::CallerNotWhitelisted); - // if self.fulfillment_whitelist.entry(caller).read() == false { - // // emit event ? - // return false; - // } // @dev If the current round is Open, set its pricing data directly if state == OptionRoundState::Open {