This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
Upgrading to webpack 4.x #773
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,72 +1,70 @@ | ||
| const { dependencies } = require('../package.json'); | ||
|
|
||
| function getVersionedPackageNames(packageNames) { | ||
| let validNumericRegex = /^\d+\.\d+\.\d+.*$/; | ||
| /* | ||
| passes: | ||
| 2.3.4 | ||
| 222.33.444 | ||
| 1.1.2-private | ||
| 1.1.2-private.0 | ||
|
|
||
| fails: | ||
| ^1.3.0 | ||
| 2.2.* | ||
| */ | ||
|
|
||
| let result = {}; | ||
| packageNames.forEach(item => { | ||
| let versionNumberWithDots = dependencies[item]; | ||
| if (!validNumericRegex.test(versionNumberWithDots)) { | ||
| throw new Error(`Package number for "${item}: ${versionNumberWithDots}" must start with a #.#.# format, ` + | ||
| `pointing at a specific version.`); | ||
| } | ||
|
|
||
| let concatenated = item + '-' + versionNumberWithDots; | ||
| let filesafeFolderName = concatenated.toLowerCase() | ||
| .replace(/[^0-9a-zA-Z]/g, '-') /* replace any non-alphanumeric with a hyphen */ | ||
| .replace(/-+/g, '-') /* and ensure that don't end up with -- or --, just a single hyphen */ | ||
| .replace(/^-+/, '') /* trim any hyphens before */ | ||
| .replace(/-+$/, '') /* and trim any at the end, as well */; | ||
|
|
||
| result[item] = filesafeFolderName; | ||
| }); | ||
| return result; | ||
| } | ||
|
|
||
| class VersionedPackageSubstitutionsPlugin { | ||
| constructor(packageNames) { | ||
| this._packageNames = packageNames | ||
| } | ||
|
|
||
| apply(compiler) { | ||
| compiler.hooks.compilation.tap('html-webpack-plugin-before-html-processing', htmlPluginData => { | ||
| let headOpeningTag = '<head>'; | ||
| let htmlHead = htmlPluginData.html.match(headOpeningTag); | ||
|
|
||
| if (htmlHead && htmlHead.length > 0) { | ||
| htmlHead = htmlHead.index; | ||
| htmlPluginData.html = htmlPluginData.html.slice(0, htmlHead) | ||
| + headOpeningTag + | ||
| ` | ||
| <script> | ||
| window.versionedPackageNames = ${JSON.stringify(this._packageNames)}; | ||
| </script> | ||
| ` + | ||
| htmlPluginData.html.slice(htmlHead + headOpeningTag.length); | ||
| } | ||
|
|
||
| htmlPluginData.html = htmlPluginData.html.replace( | ||
| /{{{versionedPackageNames\[['"](.+)['"]\]}}}/g, | ||
| (fullMatch, group1) => this._packageNames[group1] | ||
| ); | ||
|
|
||
| return htmlPluginData; | ||
| }); | ||
| } | ||
| } | ||
|
|
||
| exports.getVersionedPackageNames = getVersionedPackageNames; | ||
| // exports.VersionedPackageSubstitutionsPlugin = VersionedPackageSubstitutionsPlugin; | ||
|
There was a problem hiding this comment. Likewise, is needed for a few of the pages (TryIt and CustomFunctionsDashboard) |
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why commented out? We need it to be able to switch between alpha/beta/prod...