Upgrading to webpack 4.x #773
Conversation
WrathOfZombies
requested review from
Zlatkovsky and
nico-bellante
and removed request for
Zlatkovsky
There was a problem hiding this comment.
Bhargav, first of all, thank you very much for doing this!
I left a few comments, in particular re. two lines that were commented out, which I think will have adverse effects. Other than that, looks great!
@nico-bellante , please test this locally as well (and maybe try re-adding the two commented-out lines, and seeing what happens).
Thanks again, Bhargav!
| exports.build = build; | ||
| exports.config = config; | ||
| exports.safeExternalUrls = safeExternalUrls; | ||
| exports.localStorageKeys = localStorageKeys; | ||
| exports.sessionStorageKeys = sessionStorageKeys; | ||
| exports.experimentationFlagsDefaults = experimentationFlagsDefaults; | ||
| exports.RedirectPlugin = RedirectPlugin; | ||
| // exports.RedirectPlugin = RedirectPlugin; |
There was a problem hiding this comment.
Why commented out? We need it to be able to switch between alpha/beta/prod...
| } | ||
|
|
||
| exports.getVersionedPackageNames = getVersionedPackageNames; | ||
| exports.VersionedPackageSubstitutionsPlugin = VersionedPackageSubstitutionsPlugin; | ||
| // exports.VersionedPackageSubstitutionsPlugin = VersionedPackageSubstitutionsPlugin; |
There was a problem hiding this comment.
Likewise, is needed for a few of the pages (TryIt and CustomFunctionsDashboard)
| @@ -114,44 +114,43 @@ | |||
| "@types/js-yaml": "3.5.29", | |||
| "@types/lodash": "4.14.58", | |||
| "@types/mime": "0.0.29", | |||
| "@types/node": "7.0.12", | |||
| "@types/node": "^9.6.2", | |||
There was a problem hiding this comment.
Should you change the package.json node dependency as well? Right now it says
"node": ">=6.9.4
| "shelljs": "0.7.7", | ||
| "style-loader": "0.16.1", | ||
| "style-loader": "^0.20.3", |
There was a problem hiding this comment.
Someday you'll have to explain to me the usage of "^" -- in particular, the safety thereof (and also, how does that work from a complience/OSS perspective)
This pull request upgrades webpack to 4.x. It's currently in a partially working state.