Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Node] Change signature of startReplyChain to reduce possibility of dev error #61

Open
aosolis opened this issue Sep 14, 2017 · 1 comment
Assignees

Comments

@aosolis
Copy link
Collaborator

aosolis commented Sep 14, 2017

The current signature for startReplyChain is prone to dev error, as what's conceptually the same information could be passed in multiple locations:

  • message.address.serviceUrl vs serviceUrl parameter
  • message.address.conversation.id vs. channelId parameter
    The function can fail to return a valid address if the parameters contain inconsistent/incomplete information.

It would be better if the parameters to startReplyChain were parallel to startConversation.
startReplyChain(message: IMessage|IIsMessage, done: (err: Error, address?: IAddress) => void)
where the message's address contains all the necessary routing information.

@RamjotSingh
Copy link
Member

@BillZengMSFT Please take a look.

@iceNuts iceNuts self-assigned this Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants