Bulk syncing of missing BlockMetadata #2765
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
ganeshvanahalli
changed the base branch from
master
to
bulk-blockmetadata-api
ganeshvanahalli
changed the title
magicxyyz
requested changes
Nov 11, 2024
diegoximenes
requested changes
Nov 12, 2024
arbnode/blockmetadata.go
Outdated
| }, nil | ||
| } | ||
|
|
||
| func (b *BlockMetadataRebuilder) Fetch(ctx context.Context, fromBlock, toBlock uint64) ([]gethexec.NumberAndBlockMetadata, error) { |
There was a problem hiding this comment.
nitpick: why to export this func?
There was a problem hiding this comment.
The main reason was to enable testing of each components separately (which was done and later replaced with a system test).
But there really is no preference for me here, can always export these functions later if needed- going to make these private now
arbnode/blockmetadata.go
Outdated
| return ret | ||
| } | ||
|
|
||
| func (b *BlockMetadataRebuilder) PersistBlockMetadata(query []uint64, result []gethexec.NumberAndBlockMetadata) error { |
There was a problem hiding this comment.
nitpick: why to export this func?
Tristan-Wilson
approved these changes
Nov 18, 2024
…d locally computed hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
BlockMetadataRebuilderthat can be configured via config options--node.block-metadata-rebuilder.*that when enabled will check, in regular intervals, for missing blockMetadata in ArbDB and fetch those in bulk from an endpoint servicingarb_getRawBlockMetadatamethod introduced here and adds them to ArbDB.Resolves NIT-2838