Express lane timeboost remove express lane calling sequencer #2762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
6 tasks
…ress-lane-timeboost-remove-express-lane-calling-sequencer
Tristan-Wilson
deleted the
express-lane-timeboost-remove-express-lane-calling-sequencer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the need for the
expressLaneServiceto call the sequencer RPC directly. The reason that it was doing so previously was that our contract bindings require aContractBackendinterface passed in, which was previously only implemented byethclient.Client. This PR makes an adapter for theContractBackendinterface that provides implementations of the methods needed byexpressLaneServiceto make read only calls on theExpressLaneAuctioncontract and to watch for events.This PR is addressing @tsahee 's comment on #2561 (comment)
Testing done