Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShellCheck CI #2659

Merged
merged 6 commits into from
Sep 23, 2024
Merged

ShellCheck CI #2659

merged 6 commits into from
Sep 23, 2024

Conversation

diegoximenes
Copy link
Contributor

@diegoximenes diegoximenes commented Sep 11, 2024 •
edited
Loading

Resolves NIT-2703

Adds ShellCheck CI GitHub action.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Sep 11, 2024
@diegoximenes diegoximenes marked this pull request as ready for review September 11, 2024 13:27
eljobe
eljobe previously approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@eljobe eljobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gligneul
gligneul previously approved these changes Sep 11, 2024
View reviewed changes
.github/workflows/shellcheck-ci.yml Outdated Show resolved Hide resolved
@diegoximenes diegoximenes dismissed stale reviews from gligneul and eljobe via e8a8876 September 11, 2024 15:58
gligneul
gligneul previously approved these changes Sep 11, 2024
View reviewed changes
tsahee
tsahee previously approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegoximenes diegoximenes dismissed stale reviews from tsahee and gligneul via 82a2c25 September 23, 2024 12:57
@diegoximenes
Copy link
Contributor Author

Asking review again after conflict resolution

ganeshvanahalli
ganeshvanahalli approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@ganeshvanahalli ganeshvanahalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsahee tsahee merged commit 23a16bb into master Sep 23, 2024
15 checks passed
@tsahee tsahee deleted the shellcheck branch September 23, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganeshvanahalli ganeshvanahalli ganeshvanahalli approved these changes

@eljobe eljobe Awaiting requested review from eljobe

@tsahee tsahee Awaiting requested review from tsahee

@gligneul gligneul Awaiting requested review from gligneul

Assignees
No one assigned
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@diegoximenes @eljobe @gligneul @ganeshvanahalli @tsahee