Be more precise when selecting firstMsg in the batch poster #2646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
|
Fixed merge conflicts |
ganeshvanahalli
approved these changes
Sep 10, 2024
Tristan-Wilson
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously used firstMsg for two things in the batch poster:
For (1), we don't want to include batch posting reports which we don't bother to post on their own anyways, so firstMsg has been replaced by firstUsefulMsg in these cases. For (2), we should definitely confirm this, but based on what I remember and my reading of the inbox multiplexer I don't think delayed messages can trigger a timestamp / L1 block number based reorg. The timestamp bounds are only used by non-delayed messages as far as I can tell. Therefore, we shouldn't include them when checking if posting this batch will cause a reorg.