Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NIT-2541] Add prune-threads and prune-trie-clean-cache config option #2389

Merged
merged 9 commits into from
Jun 14, 2024
Merged

[NIT-2541] Add prune-threads and prune-trie-clean-cache config option #2389

merged 9 commits into from
Jun 14, 2024

Conversation

magicxyyz
Copy link
Contributor

@magicxyyz magicxyyz commented Jun 13, 2024 •
edited
Loading

This PR adds:

  • init.prune-threads config option that specifies number of threads used when pruning
  • init.prune-trie-clean-cache config options that sets cleans cache size to be used when traversing storage tries

pulls: OffchainLabs/go-ethereum#328

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jun 13, 2024
@magicxyyz magicxyyz changed the title Add prune threads config option [NIT-2541] Add prune threads config option Jun 13, 2024
@magicxyyz magicxyyz changed the base branch from master to cherry-pick-sendTxArgs June 14, 2024 14:46
@magicxyyz magicxyyz changed the title [NIT-2541] Add prune threads config option [NIT-2541] Add prune threads and prune clean cache config option Jun 14, 2024
@magicxyyz magicxyyz changed the title [NIT-2541] Add prune threads and prune clean cache config option [NIT-2541] Add prune-threads and prune-trie-clean-cache config option Jun 14, 2024
@magicxyyz magicxyyz changed the base branch from cherry-pick-sendTxArgs to master June 14, 2024 15:21
@magicxyyz magicxyyz marked this pull request as ready for review June 14, 2024 15:53
@magicxyyz magicxyyz changed the base branch from master to cherry-pick-sendTxArgs June 14, 2024 16:00
Base automatically changed from cherry-pick-sendTxArgs to master June 14, 2024 16:50
PlasmaPower
PlasmaPower approved these changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower merged commit c2492bd into master Jun 14, 2024
11 of 12 checks passed
@PlasmaPower PlasmaPower deleted the pruning-threads branch June 14, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PlasmaPower PlasmaPower PlasmaPower approved these changes

@Tristan-Wilson Tristan-Wilson Awaiting requested review from Tristan-Wilson

@diegoximenes diegoximenes Awaiting requested review from diegoximenes

Assignees
No one assigned
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magicxyyz @PlasmaPower