Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a regression test for the empty retryable escrow account #1976

Merged
merged 5 commits into from
Nov 21, 2023

Conversation

PlasmaPower
Copy link
Collaborator

Pulls in OffchainLabs/go-ethereum#271 to fix the issue (and also go-ethereum master, and therefore OffchainLabs/go-ethereum#268)

The test in this PR fails without that PR, as it should, but succeeds on the last released node version (and also on consensus-v10.3)

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Nov 21, 2023
tsahee
tsahee previously approved these changes Nov 21, 2023
Copy link
Contributor

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 merged commit 7d5ee32 into master Nov 21, 2023
8 checks passed
@joshuacolvin0 joshuacolvin0 deleted the empty-escrow-test branch November 21, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants