-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should the unique identifier be the same for all reports on one page? #21
Comments
Interesting idea. I have resisted dropping a cookie on the end users machine as that adds a complication, but I guess I could make the guid a session cookie without triggering too many red flags... |
actually I thought it would be enough to have a single guid for each page instance so that the errors with one page can be correlated, a session cookie isn't really necessary in most cases. |
when the guid is the same for all errors on a given page, it would also be useful to have a sequence counter for each error report so that you can sort that later. (assuming that the timestamps stored are with seconds resolution, the errors may appear with the same timestamp) |
just noticed that the error reports already have a sequence counter due to the i parameter, I'm still for keeping the id the same for all errors in one page. |
I wonder if it would be better to have the same uid when more than one error is reported on a page for one user (e.g. the user causes 2 errors and then reloads the page, then we get 4 reports that are not properly connected since they have 4 different uids).
The text was updated successfully, but these errors were encountered: