Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for HTTP/2 #116

Open
henning410 opened this issue Jun 13, 2024 · 5 comments
Open

Support for HTTP/2 #116

henning410 opened this issue Jun 13, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@henning410
Copy link

If I understand correctly, OFFAT does not currently work for HTTP/2? I tried to fuzz some API that uses HTTP/2, but OFFAT produces

RemoteDisconnected('Remote end closed connection without response')

Is support for this planned in the future?

@nrathaus
Copy link
Contributor

Unfortunately the extensive use of requests package prevent implementation of HTTP/2 as urllib3 which requests uses doesn't have nor plans to add HTTP/2

An alternative could be to migrate to: https://pypi.org/project/pycurl/ which support HTTP/2 if libcurl has HTTP/2 compiled into it

@dmdhrumilmistry dmdhrumilmistry added the enhancement New feature or request label Aug 7, 2024
@dr4g0n369
Copy link

Hello @dmdhrumilmistry, I have an idea for this. We could pass an argument like --http2 which would enable HTTP/2 and then implement it using httpx.

If that sounds good, can you assign this issue to me?

@dmdhrumilmistry
Copy link
Collaborator

Hello @dmdhrumilmistry, I have an idea for this. We could pass an argument like --http2 which would enable HTTP/2 and then implement it using httpx.

If that sounds good, can you assign this issue to me?

Hey,

Sounds good to me! but currently, I'm not planning to maintain python version anymore. I've been busy lately, but I'm porting complete codebase to golang. Currently, I'm using fasthttp which sadly doesn't support http2 (at the time of writing). If you're interested in contributing to the project, then you can create a module with interface which can support http1 (fast http), http2 (net/http) and http3 (quic-go) requests.

LMK if you'd like to pick this up. Also, Note its not necessary to implement all at once, you can implement it in phases.

Golang Codebase: https://github.com/owasp-offat/offat

@dr4g0n369
Copy link

Yes, I would surely like to take that up.

@dmdhrumilmistry
Copy link
Collaborator

I'm creating new issue in golang codebase and assigning it to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants