Items not animating

[tysonstrange]

Since commit 35b8859 seems no items will animate.

Creatures and effects seem fine.

I have tested stock otclientv8, just cloned and compiled, on nekiros TFS 8.6 downgrade and another test server of my own, but none of the items are animating.

Has anyone else tested this recent commit? Simply reverting this commit only returns the animations.

[Oen44]

Did this break old protocols without enhanced animations? Because it works with 10.98 protocol.

[tysonstrange]

Did this break old protocols without enhanced animations? Because it works with 10.98 protocol.

Possibly? Sorry, not sure what exactly how you mean. I have only tested on 8.6 and 7.72, but if I revert just this commit from a stock compile the items animate fine. Everything else seems to work fine.

Not sure if there is a game feature or something else I'd otherwise need to add, but I haven't got any higher protocol servers setup atm. It might be just an older protocol issue.

Maybe something to do with the older style spr/dats? I'm using a spr/dat not the more modern "things" tile (i forget the ext)

[Oen44]

I have only tested on 8.6 and 7.72

Then that must be 100% the case. I don't have old protocol server and client ready to use and test unfortunately.
I'm not home until Saturday so tomorrow I'll prepare fix and create pull request with the changes so you can test them and let me know if they helped so I can merge it.

[tysonstrange]

I tested 10.98 from TFS 1.4.2 just to see and confirmed all the items are animating normally.

I suspect something to do with the "GameItemAnimationPhase" game feature from protocol 9.10+

What does this change for OTC and the items animator do, is it just performance related?

[Oen44]

Not gonna lie, I completely forgot about this issue... Gonna sit down to it in an hour or so.

What does this change for OTC and the items animator do, is it just performance related?

If you have an item that has finite number of loops and you spawn that item, every other item of the same type would not animate anymore since first item already reached the loop limit. So this is pretty much a fix for such situation, someone posted video where some hamster wheel item upon transformation would not play the animation anymore when transformed again because it played 1 loop already.

[Oen44]

@tysonstrange check #30

[tysonstrange]

Rofl.

Sweet, will do when I wake up it's like 4 am now. Idk what that hamster wheel is tho lol, maybe there's no applicable items in older clients, but good to know.

Unrelated side note, the recent change that added theb uiflexbox and uigrid need to be updated for Android sln linker, as it won't compile. Minor issue I bumped into while rebuilding these latest changes.

[Oen44]

Unrelated side note, the recent change that added theb uiflexbox and uigrid need to be updated for Android sln linker, as it won't compile. Minor issue I bumped into while rebuilding these latest changes.

Thanks, fixed in 7845116

[tysonstrange]

Yeah, looks to be working alright now.