-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chromium: dunfell build fails because host include directories are used for native build #726
Comments
Just to confirm: is this something that only happens on dunfell? At first it sounds like an issue that'd be reproducible on all branches. If not, I guess the good news is that this has already been fixed in other branches :-) |
I've only ever seen it on dunfell, yes. But I only ever build |
I think not, I'd expect chromium-ozone-wayland to also have to build the native BoringSSL bits just like the X11 version. At this point I don't remember if we also build libc++ on the host. Looking at the logs above we at least build clang-native, but it seems to be using the host's libstdc++. |
I've tried to get the dunfell build working on another machine (Arch Linux), but that one already fails to compile nodejs-native (same as on my other Arch machine):
I think this is because of the same underlying error - this V8 CL suggests to me that the GCC headers are used, which internally changed some of there imports in GCC 13, leading to these errors. |
@kraj as this seems to be a dunfell-specific problem, not sure if looking at kraj/meta-clang@dunfell-clang12...kirkstone makes sense to maybe find out what fix kirkstone has that dunfell hasn't (probably in |
The nodejs-native issue seems to be different, as these other recipes are expected to use GCC by default anyway. You're not getting this error in kirkstone because Khem fixed the recipe there: openembedded/meta-openembedded@4cc7363 I think this specific issue can go away if the same fix is backported to 14.x. |
See openembedded/meta-openembedded@116bfe8 it was done exactly for supporting latest chromium so please do the preferred version thing when building chromium |
I have |
That enough for supported build hosts for dunfell. If you are using some other distro which is using gcc13 then it might be an issue and if someone can validate that this would work then proposing a backport to dunfell for meta-oe might be ok |
Yes, Arch Linux has updated to gcc13 already (Fedora 38 as well, and more distros will follow). I've confirmed that manually applying the changes from the linked patch fixes this build error. However, there's another build error that needs to be fixed: https://bugs.gentoo.org/904878 The upstream v8 fix that Gentoo backported requires a slight tweak: it uses I can provide the patch files, maybe you could then please propose adding them to meta-oe? |
I get the errors even though I meet all the requirements for dunfell:
I've also picked the commit hash e8a756b of meta-browser that provides chromium-x11-112.0.5615.165...but I don't get it compiled. Is there anything else I'm missing? |
As this is fixed with the experimental |
Example error (happens for multiple files):
(first seen here)
I checked using
bitbake -c devshell chromium-x11
and indeed, the native version uses host headers, while the cross-compile version does not:The text was updated successfully, but these errors were encountered: