Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tests to use mocker patch and mock EchoData object #1349

Open
leewujung opened this issue Jul 1, 2024 · 0 comments
Open

Upgrade tests to use mocker patch and mock EchoData object #1349

leewujung opened this issue Jul 1, 2024 · 0 comments

Comments

@leewujung
Copy link
Member

Some of the current tests (such those in #1319) run through open_raw and compute_Sv in order to test downstream functionalities that require both the Sv dataset and the correspondning EchoData object. We should upgrade these tests to use mocker patch and mock EchoData objects (I believe the core mechanism is already in place in tests/echodata/utils.py::get_mock_echodata - should probably make it a fixture that can be used elsewhere), so that we are not tied with the particularities of the test .raw files and are just testing the exact operations of these functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

1 participant