Add read-only CORS headers for UI preview #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Berezovskyi <[email protected]>
|
@berezovskyi why are we doing this? The suggested changes will be lost upon a re-generation, which defies the point of this repo. (To illustrate the use of alto.designer in the wiki) |
|
I wanted to test lyo 2.4.0.m1 on this repo and stumbled on this CORS problem |
|
I see. So are you suggesting we introduce this code change into the generator? Is it tested? |
|
Yes, I did verify the fix but not extensively. The CORS headers need to be added to every response that is embedded in an iframe, so I'd suggest to put them in the generator. But the method I'd probably put somewhere in Lyo library code.
…--
/Andrew
On 12 Nov 2018, at 09:20, Jad El-khoury <[email protected]<mailto:[email protected]>> wrote:
I see. So are you suggesting we introduce this code change into the generator? Is it tested?
And, just to be sure, is this in anyway related to these 2 bugs that we have earlier fixed?
https://bugs.eclipse.org/bugs/show_bug.cgi?id=532688
https://bugs.eclipse.org/bugs/show_bug.cgi?id=532687
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#18 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAD83vqyQxFRcG_K-J4sTebseo3P6jIPks5uuS9LgaJpZM4YYm-g>.
|
|
Not related to these 2 in any way.
…--
/Andrew
On 12 Nov 2018, at 09:20, Jad El-khoury <[email protected]<mailto:[email protected]>> wrote:
I see. So are you suggesting we introduce this code change into the generator? Is it tested?
And, just to be sure, is this in anyway related to these 2 bugs that we have earlier fixed?
https://bugs.eclipse.org/bugs/show_bug.cgi?id=532688
https://bugs.eclipse.org/bugs/show_bug.cgi?id=532687
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#18 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAD83vqyQxFRcG_K-J4sTebseo3P6jIPks5uuS9LgaJpZM4YYm-g>.
|
|
Integrated as part of LyoDesigner already F cors support #58 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #16
This change is