Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Recovery partition before OS partition #43

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sleeuwenhoek
Copy link

This way the OS disk can be expanded later on when de VHDX is enlarged.

@peterinhk
Copy link
Contributor

Nice work on the code changes. This seems to make my previous commit redundant, however, as my commit to add the "-IncludeRecoveryPartition" parameter addresses the same issue concerning the ability to expand the windows partition size.

If we move the default location of the recovery partition do we even need the "-IncludeRecoveryPartition" parameter?

Are there other potential issues that could arise due to not following Microsoft's recommended partition layout for Win10 UEFI disks (think bitlocker, etc)? (Partition Layout)

I also considered that this function is intended to create a virtual hard disk which in my experience is far more likely to be expanded in size vs when Windows is installed on a physical fixed disk. Which lead to the idea of making the recovery partition optional as opposed to moving it in the partition layout.

If I'm honest I've not found much conclusive information regarding issues from not following the recommended partition layout aside from "it's recommended, so just don't". Would love to learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants