Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Rename the module #4

Open
mscherer opened this issue Jul 28, 2016 · 7 comments
Open

Rename the module #4

mscherer opened this issue Jul 28, 2016 · 7 comments

Comments

@mscherer
Copy link
Contributor

As there is some community who may want to build more than middleman, it might make sense to rename the module to be static_builder rather than middleman_builder.

So we need to have a list of downstream user we know and be prepared to switch.

@mscherer mscherer mentioned this issue Jul 29, 2016
@duck-rh
Copy link
Contributor

duck-rh commented Sep 4, 2017

Here I have: Community / oVirt / RDO / OSCI / Gluster
(MI no more uses it)
Anything else?

@mscherer
Copy link
Contributor Author

mscherer commented Sep 4, 2017

Nope. I think we can just rename and fix. The failure would either be quite visible anyway, or wouldn't break anything but deployment of infra, so no userfacing breakage.

@duck-rh
Copy link
Contributor

duck-rh commented Sep 5, 2017

Done, let's fix now.

@duck-rh
Copy link
Contributor

duck-rh commented Sep 5, 2017

It would be nice to change the default builder_username too, but this means renaming things on the deployed machines too.

@duck-rh
Copy link
Contributor

duck-rh commented Sep 5, 2017

I fixed all of them except Gluster because I don't have access so I made a PR.

@duck-rh
Copy link
Contributor

duck-rh commented Sep 5, 2017

Updated the doc slightly in #18

@mscherer
Copy link
Contributor Author

We can just add a alias on the variable for builder_username.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants