This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Rename the module #4
Comments
Merged
Here I have: Community / oVirt / RDO / OSCI / Gluster |
Nope. I think we can just rename and fix. The failure would either be quite visible anyway, or wouldn't break anything but deployment of infra, so no userfacing breakage. |
Done, let's fix now. |
It would be nice to change the default builder_username too, but this means renaming things on the deployed machines too. |
I fixed all of them except Gluster because I don't have access so I made a PR. |
Updated the doc slightly in #18 |
We can just add a alias on the variable for builder_username. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
As there is some community who may want to build more than middleman, it might make sense to rename the module to be static_builder rather than middleman_builder.
So we need to have a list of downstream user we know and be prepared to switch.
The text was updated successfully, but these errors were encountered: