Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge fixes from Develop/main374 into ECC branch #2844

Closed
wants to merge 14 commits into from

Conversation

romanett
Copy link
Contributor

No description provided.

romanett and others added 9 commits October 23, 2024 17:42
returndiagnostics was not propagated to recreated and reconnected sessions
* an exception in FetchOperationLimits may have skipped applying the configured operation limits on the server
JSON ReadEnumeratedString does not decode the number in e.g. "Red_0".
JSON reencode of JSON content in an extension object runs into an encoder error.
* improve crl handling in certificate stores by not loading CRL with invalid or unsupported content. Hence the revocation check for such certificates may fail.
…ed lower/uppercase letters in the <hostname> of the Uri.(#2837)

Uri.TryCreate lower cases the hostnames. Switch always back to the legacy implementation which maintains the casing.
Copy link

codecov bot commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 16 lines in your changes missing coverage. Please review.

Project coverage is 55.10%. Comparing base (3672ebe) to head (56dd06d).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
Stack/Opc.Ua.Core/Types/Utils/Utils.cs 33.33% 3 Missing and 3 partials ⚠️
Libraries/Opc.Ua.Client/Session/Session.cs 50.00% 3 Missing and 1 partial ⚠️
...es/Opc.Ua.PubSub/Transport/MqttPubSubConnection.cs 60.00% 0 Missing and 2 partials ⚠️
...Security/Certificates/DirectoryCertificateStore.cs 75.00% 2 Missing ⚠️
Stack/Opc.Ua.Core/Types/Encoders/JsonDecoder.cs 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2844      +/-   ##
==========================================
- Coverage   57.23%   55.10%   -2.13%     
==========================================
  Files         352      352              
  Lines       75520    75539      +19     
  Branches    15988    15990       +2     
==========================================
- Hits        43223    41625    -1598     
- Misses      27870    29487    +1617     
  Partials     4427     4427              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mregen and others added 5 commits November 21, 2024 10:16
- Channels are not disposed (client and server)
- During long running tests an HMAC object leak was observed.
- The HMAC and SymmetricSign objects were not disposed after use, leading to a small incremental memory leak per key renewal. 
- The channel token lifetime is calculated by the system clock, which can change. Instead use the continous HiResClock.TickCount to calculate the lifetimes.
- Token renewal and connection requests are not removed from the request dictionary

Improvements:
- Make ChannelToken disposable. Dispose channels.
- Dispose HMAC and SymmetricSign objects after use.
- Use TickCount to calculate key renewal and key expiry.
- Introduce a 5% jitter to the token renewal timer, to avoid token renewal storms.
- Reduce the allocation per use of the HMAC objects by using ReadOnlySpan and avoid MemoryStream.
…el (#2850)

Clients that are failing too often to pass the security validationin a certain interval of time with the Basic128 security profile are now tracked and blocked.
ValidateRolePermissions for MIs montioring the Value of a Node
… user identity to allow validation when no session is present (#2832)

* ValidateRolePermissions for MIs montioring the Value of a Node
* allow validation of user identity also in case of disconnected session
* support .NET 9.0 build
* provide a helper to use the X509CertificateLoader also on older .NET versions
@romanett romanett closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants