From 0301038343a20e230eafabdaf2af7f637dc810a5 Mon Sep 17 00:00:00 2001 From: SriHV Date: Mon, 16 Dec 2024 18:03:49 +0000 Subject: [PATCH 1/4] adjusted space between buttons --- src/components/button/_button.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/button/_button.scss b/src/components/button/_button.scss index 076ff11f76..18925664ef 100644 --- a/src/components/button/_button.scss +++ b/src/components/button/_button.scss @@ -569,6 +569,6 @@ $button-shadow-size: 3px; .ons-btn, a { - margin: 0 1rem 1rem 0; + padding: 0 1.5rem 1rem 0; } } From 5d03ccbe68afe48eae2453ff244d2b77020c015b Mon Sep 17 00:00:00 2001 From: SriHV Date: Tue, 17 Dec 2024 11:36:22 +0000 Subject: [PATCH 2/4] Adding visual tests --- ...nents_button_example-button-group_0_document_0_desktop.png | 4 ++-- ...onents_button_example-button-group_0_document_1_tablet.png | 4 ++-- ...onents_button_example-button-group_0_document_2_mobile.png | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/backstop_data/bitmaps_reference/ds-vr-test__components_button_example-button-group_0_document_0_desktop.png b/backstop_data/bitmaps_reference/ds-vr-test__components_button_example-button-group_0_document_0_desktop.png index 073c5bd7a8..06e0927a9a 100644 --- a/backstop_data/bitmaps_reference/ds-vr-test__components_button_example-button-group_0_document_0_desktop.png +++ b/backstop_data/bitmaps_reference/ds-vr-test__components_button_example-button-group_0_document_0_desktop.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:67ea8eb0705c1d803762190b653c450e6c614f17bcb56d1b09d4d25ebacfba30 -size 14186 +oid sha256:988032ac64ad1f9e22080a8eaaaa15bad375cdda8c5305ce34274b13dc9ba0e9 +size 14177 diff --git a/backstop_data/bitmaps_reference/ds-vr-test__components_button_example-button-group_0_document_1_tablet.png b/backstop_data/bitmaps_reference/ds-vr-test__components_button_example-button-group_0_document_1_tablet.png index f4896a3df2..0ee0e14cd7 100644 --- a/backstop_data/bitmaps_reference/ds-vr-test__components_button_example-button-group_0_document_1_tablet.png +++ b/backstop_data/bitmaps_reference/ds-vr-test__components_button_example-button-group_0_document_1_tablet.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:d8b152b09273c19d7e02ca4bb69189e153d248711ba8e66a02e4d38561da4482 -size 9032 +oid sha256:8a164b151cf8dfa6b3fb446a119ce506e552d876eb770aa589b31d2ce202c351 +size 9031 diff --git a/backstop_data/bitmaps_reference/ds-vr-test__components_button_example-button-group_0_document_2_mobile.png b/backstop_data/bitmaps_reference/ds-vr-test__components_button_example-button-group_0_document_2_mobile.png index aba1f68d63..dbfbb2544d 100644 --- a/backstop_data/bitmaps_reference/ds-vr-test__components_button_example-button-group_0_document_2_mobile.png +++ b/backstop_data/bitmaps_reference/ds-vr-test__components_button_example-button-group_0_document_2_mobile.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:53b21b44f05cf83164c6e491b2aa15377683c556eb542b1c263bfda355bf8e7d -size 6033 +oid sha256:b830ff766fa6b0cfdeb021f091df141c5ddafa60dba3a366304bf946ecca2cfd +size 6029 From 6032d2e8bdc4ca88bf8257257f6d70482f7f4c4d Mon Sep 17 00:00:00 2001 From: SriHV <123635670+SriHV@users.noreply.github.com> Date: Tue, 17 Dec 2024 14:50:02 +0000 Subject: [PATCH 3/4] Update src/components/button/_button.scss Co-authored-by: rmccar <42928680+rmccar@users.noreply.github.com> --- src/components/button/_button.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/button/_button.scss b/src/components/button/_button.scss index 18925664ef..12addc8838 100644 --- a/src/components/button/_button.scss +++ b/src/components/button/_button.scss @@ -569,6 +569,6 @@ $button-shadow-size: 3px; .ons-btn, a { - padding: 0 1.5rem 1rem 0; + margin: 0 1.5rem 1rem 0; } } From 79a018026d986073a7c26f997d2e92d08100883a Mon Sep 17 00:00:00 2001 From: SriHV Date: Tue, 17 Dec 2024 15:18:51 +0000 Subject: [PATCH 4/4] changes in visual tests --- ...nents_button_example-button-group_0_document_0_desktop.png | 4 ++-- ...onents_button_example-button-group_0_document_1_tablet.png | 4 ++-- ...onents_button_example-button-group_0_document_2_mobile.png | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/backstop_data/bitmaps_reference/ds-vr-test__components_button_example-button-group_0_document_0_desktop.png b/backstop_data/bitmaps_reference/ds-vr-test__components_button_example-button-group_0_document_0_desktop.png index 06e0927a9a..2680887f75 100644 --- a/backstop_data/bitmaps_reference/ds-vr-test__components_button_example-button-group_0_document_0_desktop.png +++ b/backstop_data/bitmaps_reference/ds-vr-test__components_button_example-button-group_0_document_0_desktop.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:988032ac64ad1f9e22080a8eaaaa15bad375cdda8c5305ce34274b13dc9ba0e9 -size 14177 +oid sha256:7f96539c3e58c205968c560c3f1115ffccea5a285bd0c12ff198b822908fa3b5 +size 14187 diff --git a/backstop_data/bitmaps_reference/ds-vr-test__components_button_example-button-group_0_document_1_tablet.png b/backstop_data/bitmaps_reference/ds-vr-test__components_button_example-button-group_0_document_1_tablet.png index 0ee0e14cd7..771aff4891 100644 --- a/backstop_data/bitmaps_reference/ds-vr-test__components_button_example-button-group_0_document_1_tablet.png +++ b/backstop_data/bitmaps_reference/ds-vr-test__components_button_example-button-group_0_document_1_tablet.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:8a164b151cf8dfa6b3fb446a119ce506e552d876eb770aa589b31d2ce202c351 -size 9031 +oid sha256:9057e9b897ea1d8504f8d5594e12a826280bc4c88311d30e09fb9f27906a5a2d +size 9022 diff --git a/backstop_data/bitmaps_reference/ds-vr-test__components_button_example-button-group_0_document_2_mobile.png b/backstop_data/bitmaps_reference/ds-vr-test__components_button_example-button-group_0_document_2_mobile.png index dbfbb2544d..f1956d8e85 100644 --- a/backstop_data/bitmaps_reference/ds-vr-test__components_button_example-button-group_0_document_2_mobile.png +++ b/backstop_data/bitmaps_reference/ds-vr-test__components_button_example-button-group_0_document_2_mobile.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:b830ff766fa6b0cfdeb021f091df141c5ddafa60dba3a366304bf946ecca2cfd -size 6029 +oid sha256:02ca0247ddf43b925cfad05c59d4566589e376e57df09a23e3c89a0e6ad24b23 +size 6032