From fc895a90565c5598bfa58f9fec6d9a981dc793be Mon Sep 17 00:00:00 2001 From: Richard McCarthy Date: Thu, 14 Sep 2023 13:23:14 +0100 Subject: [PATCH 1/2] update pr template add pr checks and label checks --- .github/PULL_REQUEST_TEMPLATE.md | 15 ++++++++++++++- .github/release.yml | 6 ++++++ .github/workflows/check-checklist.yml | 17 +++++++++++++++++ .github/workflows/check-labels.yml | 22 ++++++++++++++++++++++ 4 files changed, 59 insertions(+), 1 deletion(-) create mode 100644 .github/workflows/check-checklist.yml create mode 100644 .github/workflows/check-labels.yml diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index b2b2ba2a73..db9a7acf2f 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,5 +1,18 @@ + + ### What is the context of this PR? + Describe what you have changed and why, link to other PRs or Issues as appropriate. -### How to review +### How to review this PR + Describe the steps required to test the changes (include screenshots if appropriate). + +### Checklist + +This needs to be completed by the person raising the PR. + + + +- [ ] I have selected the correct Project for this PR (Design System) and selected the correct status +- [ ] I have selected the correct Assignee diff --git a/.github/release.yml b/.github/release.yml index 6e2f1f4ba6..5f2dbc990d 100644 --- a/.github/release.yml +++ b/.github/release.yml @@ -7,6 +7,9 @@ changelog: labels: - Component - Pattern + - title: Accessibility improvements + labels: + - Accessibility - title: Enhancements labels: - Enhancement @@ -16,6 +19,9 @@ changelog: - title: Documentation labels: - Documentation + - title: Dependency updates + labels: + - Dependencies - title: Other changes labels: - "*" diff --git a/.github/workflows/check-checklist.yml b/.github/workflows/check-checklist.yml new file mode 100644 index 0000000000..60a62e7333 --- /dev/null +++ b/.github/workflows/check-checklist.yml @@ -0,0 +1,17 @@ +name: Checklist Checker +on: + pull_request: + types: + - opened + - edited + - synchronize + - reopened + +jobs: + check-tasks: + name: Check tasks + runs-on: ubuntu-latest + steps: + - uses: mheap/require-checklist-action@v2 + with: + requireChecklist: false diff --git a/.github/workflows/check-labels.yml b/.github/workflows/check-labels.yml new file mode 100644 index 0000000000..eaa7ba5fa3 --- /dev/null +++ b/.github/workflows/check-labels.yml @@ -0,0 +1,22 @@ +name: Label Checker +on: + pull_request: + types: + - opened + - synchronize + - reopened + - labeled + - unlabeled + +jobs: + check-labels: + name: Check labels + runs-on: ubuntu-latest + permissions: + pull-requests: read + steps: + - uses: docker://onsdigital/github-pr-label-checker:v1.2.7 + with: + one_of: Breaking changes,Accessibility,Bug,Documentation,Dependencies,Enhancement,Example + none_of: Awaiting resource,Do not merge,Duplicate,Needs validating,Not doing + repo_token: ${{ secrets.GITHUB_TOKEN }} From 444c8c45cc0edd4433f1cb031d2430214d940a5d Mon Sep 17 00:00:00 2001 From: Richard McCarthy Date: Wed, 20 Sep 2023 15:17:01 +0100 Subject: [PATCH 2/2] add extra checkbox --- .github/PULL_REQUEST_TEMPLATE.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index db9a7acf2f..15d5b095e9 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -16,3 +16,4 @@ This needs to be completed by the person raising the PR. - [ ] I have selected the correct Project for this PR (Design System) and selected the correct status - [ ] I have selected the correct Assignee +- [ ] I have linked the correct Issue