[Bug]: data-qa="error-link-<number>" attribute removed in version 72 of DS

[petechd]

Describe the bug

When I try to run functional test suites in eq-questionnaire-runner application (the getText() command):

it breaks not able to find the data-qa="error-link-<number>" that was previously present and used to generate elements for our functional tests:

Seems like the data-qa="error-link-<number>" attribute was removed from the template, the only data-qa is "error-list":

Expected behaviour / outcome

Attribute should be present in the template for the first error panel: data-qa="error-link-1.

List the steps necessary to reproduce the bug

Open a survey in eq-questionnaire-runner app after updating the Design System version from 71 to 72 and investigate the page template.

Additional context

No response

What version of the ONS Design System are you using?

72.0.1

What device(s) are you using?

Desktop

What operating system(s) are you using?

macOS

What browser(s) are you using?

Chrome

[rmccar]

Had an initial investigation into this, its because of some changes to the list component we no longer set custom attributes on the link element which we may need to rethink and potentially set the attributes on the link when it is available.
During this investigation I noticed this is complicated by the fact we allow setting of list level attributes and list item level attributes. When there is an ordered list but there is only one item the list is rendered as a single <p> tag. This means there is no list level element so both types of attributes get set on the <p> element. In this case we may just need to work out a way of setting them or note in the documentation that only the item one will be set. Currently when setting the same named attribute for both like data-qa which is often used the list level one is the only one that is set as it overwrites the item level one. Which is what is happening here and causing this error in the tests mentioned above.

[MagdalenaLarge]

@petechd, thank you for raising this issue. Team will investigate best solution for it and we will come back to you soon.