Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate and adjust the line height on details tabs #3393

Closed
rmccar opened this issue Oct 8, 2024 · 0 comments · Fixed by #3432
Closed

Investigate and adjust the line height on details tabs #3393

rmccar opened this issue Oct 8, 2024 · 0 comments · Fixed by #3432
Assignees
Labels
Enhancement Change of existing feature Medium priority

Comments

@rmccar
Copy link
Contributor

rmccar commented Oct 8, 2024

As a user,
I want the line height on details tabs to be consistent with font being used
so that it aligns properly with the grid and provides a clean and organised layout.

Description
Currently it is 2.25rem. Line high should not be specified in the Component, but driven by the font, if possible.

Acceptance Criteria:

  1. Investigate the current line height settings on details tabs.
  2. Identify any discrepancies or misalignments with the grid.
  3. Adjust the line height settings to ensure that details tabs sit correctly on the grid.
  4. Verify that the changes are consistent across different screen sizes and devices.
  5. Ensure that the visual appearance of the details tabs is improved and aligns with the overall design guidelines.

Visualisation

Screenshot 2024-10-08 at 16 32 06

Link to the issue on Figma https://www.figma.com/design/Wr9b6pK35euFoA6xq3G9Ld/Grid-review?node-id=0-1&node-type=canvas&m=dev

@rmccar rmccar added the Enhancement Change of existing feature label Oct 8, 2024
@MagdalenaLarge MagdalenaLarge changed the title Investigate the line height on details tabs Investigate and adjust the line height on details tabs Oct 23, 2024
@SriHV SriHV self-assigned this Nov 11, 2024
@SriHV SriHV linked a pull request Nov 20, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Change of existing feature Medium priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants