From f3b41f09ce92184030410c7659d8182ae8f9dc13 Mon Sep 17 00:00:00 2001 From: Richard McCarthy Date: Tue, 17 Sep 2024 13:07:54 +0100 Subject: [PATCH] fix summary list spacing to match summary --- ...ponents_list_example-summary-list_0_document_0_desktop.png | 4 ++-- ...mponents_list_example-summary-list_0_document_1_tablet.png | 4 ++-- ...mponents_list_example-summary-list_0_document_2_mobile.png | 4 ++-- src/components/list/_list.scss | 2 ++ src/components/list/example-summary-list.njk | 4 +++- 5 files changed, 11 insertions(+), 7 deletions(-) diff --git a/backstop_data/bitmaps_reference/ds-vr-test__components_list_example-summary-list_0_document_0_desktop.png b/backstop_data/bitmaps_reference/ds-vr-test__components_list_example-summary-list_0_document_0_desktop.png index e1f1b1df74..6a1cbc60e7 100644 --- a/backstop_data/bitmaps_reference/ds-vr-test__components_list_example-summary-list_0_document_0_desktop.png +++ b/backstop_data/bitmaps_reference/ds-vr-test__components_list_example-summary-list_0_document_0_desktop.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:bb13667ddddf83ddda3c6386854e6d69e2f7c7fea3a8a32120af5ed95ed450df -size 16478 +oid sha256:a80837903241b6c9c9046cb9734b16944c992969e90625a964320f0f473d7ee3 +size 16714 diff --git a/backstop_data/bitmaps_reference/ds-vr-test__components_list_example-summary-list_0_document_1_tablet.png b/backstop_data/bitmaps_reference/ds-vr-test__components_list_example-summary-list_0_document_1_tablet.png index cac1c01469..cef50594ff 100644 --- a/backstop_data/bitmaps_reference/ds-vr-test__components_list_example-summary-list_0_document_1_tablet.png +++ b/backstop_data/bitmaps_reference/ds-vr-test__components_list_example-summary-list_0_document_1_tablet.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:ead2dab152a3bbdd2af28b6465d62ac4553dc4721e3c2e48c260d7b874f671c6 -size 11399 +oid sha256:ee9c3aedb9fc7ecbd54df53141be63e18085387efa1396b2b2cb7ba8f5ac6bf4 +size 11625 diff --git a/backstop_data/bitmaps_reference/ds-vr-test__components_list_example-summary-list_0_document_2_mobile.png b/backstop_data/bitmaps_reference/ds-vr-test__components_list_example-summary-list_0_document_2_mobile.png index df759651e7..875088032e 100644 --- a/backstop_data/bitmaps_reference/ds-vr-test__components_list_example-summary-list_0_document_2_mobile.png +++ b/backstop_data/bitmaps_reference/ds-vr-test__components_list_example-summary-list_0_document_2_mobile.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:dad0ab15906634fa5fd940c8c1cc8b85d184f84db30d6c27039870900815bf4e -size 8326 +oid sha256:13ec35b4dd6ee7546d0671f19b1e48b6e8089218f2f8c0e6cca3acdf292e8f95 +size 8534 diff --git a/src/components/list/_list.scss b/src/components/list/_list.scss index a55ca32eb3..2f48d02f1e 100644 --- a/src/components/list/_list.scss +++ b/src/components/list/_list.scss @@ -109,8 +109,10 @@ } .ons-list__prefix, .ons-list__suffix { + margin-right: 0; &--icon-check .ons-icon { fill: var(--ons-color-leaf-green) !important; + margin-right: 1rem; } } } diff --git a/src/components/list/example-summary-list.njk b/src/components/list/example-summary-list.njk index 37abcf2290..8d2824d22f 100644 --- a/src/components/list/example-summary-list.njk +++ b/src/components/list/example-summary-list.njk @@ -1,10 +1,12 @@ {% from "components/list/_macro.njk" import onsList %} {{ onsList({ + "iconPosition": "before", "variants": "summary", "itemsList": [ { - "text": 'birth certificate' + "text": 'birth certificate', + "iconType": "check" }, { "text": 'national insurance number'