From f29408d8f16b8c6c53ad2adc9fd676d82d29f4e0 Mon Sep 17 00:00:00 2001 From: SidraJaved Date: Thu, 18 Jan 2024 11:27:49 +0000 Subject: [PATCH 1/2] upgrade: upgrading node version from 16 to 18.x Refs: BLAIS5-4053 --- .github/workflows/test.js.yml | 4 ++-- appengine_templates/app.yaml.tpl | 2 +- package.json | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/test.js.yml b/.github/workflows/test.js.yml index ba5d063..3386c43 100644 --- a/.github/workflows/test.js.yml +++ b/.github/workflows/test.js.yml @@ -11,7 +11,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node-version: [ 16.x ] + node-version: [ 18.x ] steps: - uses: actions/checkout@v2 - name: Use Node.js ${{ matrix.node-version }} @@ -24,7 +24,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node-version: [ 16.x ] + node-version: [ 18.x ] steps: - uses: actions/checkout@v2 - name: Use Node.js ${{ matrix.node-version }} diff --git a/appengine_templates/app.yaml.tpl b/appengine_templates/app.yaml.tpl index c8ed45e..16b793d 100644 --- a/appengine_templates/app.yaml.tpl +++ b/appengine_templates/app.yaml.tpl @@ -1,5 +1,5 @@ service: bam-ui -runtime: nodejs16 +runtime: nodejs18 vpc_access_connector: name: projects/_PROJECT_ID/locations/europe-west2/connectors/vpcconnect diff --git a/package.json b/package.json index b886b62..8185743 100644 --- a/package.json +++ b/package.json @@ -7,7 +7,7 @@ "start": "node ./dist/index.js", "start-server": "tsc --project tsconfig.server.json && node ./dist/index.js | pino-pretty -c -t", "start-react": "react-scripts start", - "build-react": "react-scripts build", + "build-react": "react-scripts --openssl-legacy-provider build", "test": "jest --coverage --watchAll=false", "gcp-build": "react-scripts build && tsc --project tsconfig.server.json", "lint-fix": "node_modules/.bin/eslint . --fix", @@ -105,4 +105,4 @@ "@types/react": "17.0.14", "@types/react-dom": "17.0.14" } -} +} \ No newline at end of file From 3c8676a4cff84332a9920d1d5f6326102775a807 Mon Sep 17 00:00:00 2001 From: SidraJaved Date: Thu, 18 Jan 2024 11:38:28 +0000 Subject: [PATCH 2/2] fix: gcp-build script with right flag --openssl-legacy-provider to work with latest node version, failed to deploy in sandbox, Refs: BLAIS5-4053 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 8185743..1f2d82a 100644 --- a/package.json +++ b/package.json @@ -9,7 +9,7 @@ "start-react": "react-scripts start", "build-react": "react-scripts --openssl-legacy-provider build", "test": "jest --coverage --watchAll=false", - "gcp-build": "react-scripts build && tsc --project tsconfig.server.json", + "gcp-build": "react-scripts --openssl-legacy-provider build && tsc --project tsconfig.server.json", "lint-fix": "node_modules/.bin/eslint . --fix", "lint": "yarn eslint .", "dev": "concurrently --kill-others-on-fail \"yarn start-server\" \"yarn start-react\""