-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5 parser bug #6
5 parser bug #6
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6 +/- ##
==========================================
- Coverage 91.01% 90.71% -0.31%
==========================================
Files 6 6
Lines 178 183 +5
==========================================
+ Hits 162 166 +4
- Misses 16 17 +1 ☔ View full report in Codecov by Sentry. |
Thanks @lpicci96 my only question would be about setting types vs doing something like on the importers package + pyarrow. That way we let that engine figure out the right data types, instead of hardcoding. What do you think? |
@lpicci96 we should incorporate into bblocks |
SCALE: 1000000
. This change first coerces non numeric values to nulls and then converts specific columns to int64Closes #5