Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] SR Creation Fails with TypeError and Broken Measurement Navigation due to Missing Thumbnail References #4547

Open
rmerzak opened this issue Nov 24, 2024 · 0 comments
Labels
Awaiting Reproduction Can we reproduce the reported bug?

Comments

@rmerzak
Copy link

rmerzak commented Nov 24, 2024

Describe the Bug

When using the OHIF Viewer platform, there appears to be two connected issues:

Main Bug:

Occurs when trying to create a Structured Report (SR) after drawing measurements
The system throws a TypeError indicating it can't read properties of undefined
Specifically, it's trying to read an 'indexOf' property from something that is undefined
The error originates in the measurement annotation display filtering logic
Screen Shot 2024-11-24 at 8 43 21 PM

Screen Shot 2024-11-24 at 8 44 02 PM

Related Navigation Issue:

The "jumpToThumbnail" function fails because it cannot find the expected thumbnail
This prevents users from properly navigating between different measurements
The error message indicates "displaySet thumbnail not found"

Screen Shot 2024-11-24 at 8 54 49 PM

Steps to Reproduce

Here are the detailed steps to reproduce the bug in OHIF Viewer:

Initial Setup:

  1. Open OHIF Viewer

  2. Load a US modality exam into the viewer

Create Measurements:

  1. Select a measurement tool (e.g., Length, Arrow, Bidirectional)

  2. Draw several measurements on the image

  3. Save/confirm each measurement

SR Creation Attempt:

  1. Navigate to the SR creation feature/button

  2. Attempt to create a Structured Report (SR) from the measurements

  3. This triggers the "Cannot read properties of undefined" error

Try Navigation:

Attempt to navigate between the measurements
The system fails with "jumpToThumbnail: displaySet thumbnail not found" error

The current behavior

During SR Creation:

When attempting to create a Structured Report after drawing measurements:

  • System throws a TypeError error
  • Error message: "Cannot read properties of undefined (reading 'indexOf')"

Measurement Navigation Issues:

  • Attempting to navigate between measurements fails
  • System reports "jumpToThumbnail: displaySet thumbnail not found"

The expected behavior

The Expected Behavior in OHIF Viewer:

SR Creation Process:

After drawing measurements on an image:

  • SR creation should execute smoothly without errors

  • All measurements should be properly included in the SR

  • System should generate a valid Structured Report

  • User should receive confirmation of successful SR creation

Measurement Navigation:

Should be able to easily navigate between measurements using the interface
Clicking on measurement items should:

  • Jump to the correct image/slice

  • Highlight the selected measurement

OS

macos 10.15.7

Node version

20.6.1

Browser

Version 124.0.6367.93

@rmerzak rmerzak added the Awaiting Reproduction Can we reproduce the reported bug? label Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Reproduction Can we reproduce the reported bug?
Projects
None yet
Development

No branches or pull requests

1 participant