Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Loading of DICOMs has changed order in 3.8 #4531

Open
salimkanoun opened this issue Nov 19, 2024 · 2 comments
Open

[Bug] Loading of DICOMs has changed order in 3.8 #4531

salimkanoun opened this issue Nov 19, 2024 · 2 comments
Labels
Awaiting Reproduction Can we reproduce the reported bug?

Comments

@salimkanoun
Copy link
Contributor

Describe the Bug

See video for the same case,
The first loading is the current main branche
The second loading is the version before 2.0 conrestone upgrade
https://github.com/user-attachments/assets/add8bfe8-42fb-4e45-bf33-a5854d1a5376

I would be better to keep topToBottum and make it configurable,
The loading process probably needs some rethinking as previous loading feature such as InterleaveTopToButtom are now not accessible any,

Probably we need to define loading strategy :

  • Globally in the app-config
  • Per hanging protocol with customLoadStrategy, if defined it takes priority on the global setting.

The definition of the loading strategy should probably have 2 parameters defined separatly :

  • The loading strategy : Interleave, Nth ....
  • The orientation : Top to bottom, bottom To Top ....

Steps to Reproduce

Load image

The current behavior

bottom to top

The expected behavior

top to bottom

OS

linux

Node version

20

Browser

Chrome latest

@salimkanoun salimkanoun added the Awaiting Reproduction Can we reproduce the reported bug? label Nov 19, 2024
@sedghi
Copy link
Member

sedghi commented Nov 21, 2024

This seems to be related to htjtk and progressive rendering changes

if i do this it works properly

CleanShot 2024-11-21 at 14 40 05@2x

Most likely this PR
cornerstonejs/cornerstone3D#1471

@sedghi
Copy link
Member

sedghi commented Nov 21, 2024

@wayfarer3130 I don't think the

imageRetrieveMetadataProvider.add(
      'volume',
      cornerstone.ProgressiveRetrieveImages.interleavedRetrieveStages
    );

plays nice with our custom strategies

I see we removed the

CleanShot 2024-11-21 at 14 48 39@2x

Do you know what is causing this regression?

I think the interleavedRetrieveConfiguration is per volume, but then at OHIF we have across volume interleave and that gets broken i guess if used together with this interleave progressive. I guess it makes sense since if HP defines a strategy for load, any per volume load should get ignored

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Reproduction Can we reproduce the reported bug?
Projects
None yet
Development

No branches or pull requests

2 participants