Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dependencies to suggest #492

Open
egillax opened this issue Oct 18, 2024 · 0 comments
Open

Move dependencies to suggest #492

egillax opened this issue Oct 18, 2024 · 0 comments

Comments

@egillax
Copy link
Collaborator

egillax commented Oct 18, 2024

There are still a number of dependencies that could be moved to suggest which would decrease the installation load for regular users:

  • mgcv - only used when plotting smooth calibration with cubic splines
  • polsplines and survival - only used with survival models, which is only cox regression now
  • reticulate - only used when using scikit learn models or certain feature engineering methods
  • ggplot2 - only used when calling plotPlp or plotting learning curves
  • gridExtra - only used in plotPlp

preliminary results indicate that with these in suggest we would use 73 packages instead of 94 for a regular install.

We need to make sure all usages of these packages are behind ensure_installed calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant