Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests suite wholly disabled? #466

Open
Apteryks opened this issue Oct 29, 2024 · 3 comments
Open

Tests suite wholly disabled? #466

Apteryks opened this issue Oct 29, 2024 · 3 comments

Comments

@Apteryks
Copy link

Hi,

Looking at

if (OGRE_BUILD_TESTS AND 0)
, I see the test suite is disabled (0 is equivalent to FALSE in CMake expressions, right?).

Should it still be disabled? The former ogre (not next) appears to have a working test suite.

@darksylinc
Copy link
Member

Hi!

The old test suit was never ported to OgreNext so it was disabled. We have newer tests that do work.

We do not have formal coverage reports if that's what you're asking. It was in the roadmap for 3.0 but it was postponed.

@Apteryks
Copy link
Author

Apteryks commented Oct 30, 2024

Oh! Would it be possible to reinstate ENABLE_TESTING() (see:

ENABLE_TESTING()
) if there are new tests? That takes care of adding a 'test' target, which makes it easy to run the test suite.

@Apteryks
Copy link
Author

I checked a bit and I don't see the use of CTest's add_test macro for theses tests, so I guess I'd need to run each binary manually; the github CI here doesn't seem to be running these tests so it's hard to tell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants