Add support for exporting notes

[OGKevin]

Add the ability to include notes made in the export.

Relates to: bitwiseops#2

[MichaelLepori]

Nice! Thank you @OGKevin

[OGKevin]

@MichaelLepori Are you able to do a test again, before I merge the MR?

https://github.com/OGKevin/obsidian-kobo-highlights-import/releases/tag/1.3.0-beta.0

[MichaelLepori]

Yes sure! I am ready... -- Michael Lepori Il giovedì 15 settembre 2022 20:03:46 CEST, Kevin Hellemun ***@***.***> ha scritto: @MichaelLepori Are you able to do a test again, before I merge the MR? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

[OGKevin]

@MichaelLepori Cool, could you give https://github.com/OGKevin/obsidian-kobo-highlights-import/releases/tag/1.3.0-beta.0 a try please 🙏🏾

[MichaelLepori]

Hi OGKevin, Oh Man....that's nice what you did!! Hier the Result: Why ist there a space more on the first line? I tried Multiline on the Note of a Highlight: 2nd Question: How does it work with the sorting? The first example ist the last Highlight Note on the top.The second example ist the last Note at the end. Have a nice weekend. All the Best.

…

-- Michael Lepori Il venerdì 16 settembre 2022 20:52:31 CEST, Kevin Hellemun ***@***.***> ha scritto: @MichaelLepori Cool, could you give https://github.com/OGKevin/obsidian-kobo-highlights-import/releases/tag/1.3.0-beta.0 a try please 🙏🏾 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

[OGKevin]

@MichaelLepori I think you wanted to send an attachment? I think that is not possible via email. You must do that via GitHub directly.

The code that touches ordering has no changes in this release 🤔
I don't see any order issues in my diff.
The way ordering is done is based on the chapter the note has been taken.
If you have 2 highlights within the same chapter, then the ordering can be incorrect 🤔
Is this what you are experiencing?

[MichaelLepori]

Yes, I sent you these Pictures: Can you see those now? Thank you. Michael Lepori Von meinem iPhone gesendet

…

Am 17.09.2022 um 10:38 schrieb Kevin Hellemun ***@***.***>:  @MichaelLepori I think you wanted to send an attachment? I think that is not possible via email. You must do that via GitHub directly. The code that touches ordering has no changes in this release 🤔 I don't see any order issues in my diff. The way ordering is done is based on the chapter the note has been taken. If you have 2 highlights within the same chapter, then the ordering can be incorrect 🤔 Is this what you are experiencing? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

[OGKevin]

@MichaelLepori Nope

[MichaelLepori]

@OGKevin I write hier on GitHub:
Hier the Result:

Why ist there a space more on the first line?

I tried Multiline on the Note of a Highlight.

2nd Question:
How does it work with the sorting?
The first example ist the last Highlight Note on the top.The second example ist the last Note at the end.

[OGKevin]

@MichaelLepori The extra space should be fixed in https://github.com/OGKevin/obsidian-kobo-highlights-import/releases/tag/1.3.0-beta.1.

Regarding sorting, it sorts based on an internal ID that is stored in the database:

obsidian-kobo-highlights-import/src/database/Highlight.ts

Lines 80 to 81 in 025c835

	return a.content.bookTitle.localeCompare(b.content.bookTitle) ||
	a.content.contentId.localeCompare(b.content.contentId);

For some reason, the ID of chapter27 is sorted above the ID of chapter1. The only way to find out why is to see what the values of the ContentID is.

If you would like, I can add debug logging in the next release that you can use to extract this information, and then we can figure out why the sorting is not working for this book.