[14.0][IMP] shopfloor_reception improve confirmation #717

TDu · 2023-08-10T06:49:05Z

No description provided.

OCA-git-bot · 2023-08-10T06:49:14Z

Hi @JuMiSanAr, @mmequignon,
some modules you are maintaining are being modified, check this out!

simahawk · 2023-08-21T14:58:21Z

shopfloor_reception_mobile/static/src/scenario/reception_states.js

@@ -240,6 +240,7 @@ export const reception_states = function () {
                        picking_id: this.state.data.picking.id,
                        selected_line_id: this.line_being_handled.id,
                        location_name: location.text,
+                        // FIXME if it is always set to true, it is not really used ?


don't we fix it here?

Actually not. This is not the same endpoint that is called. So this one has not been changed.
Because the frontend always return true, I did not see the point of updating it, maybe the question is should it be removed ?

mt-software-de · 2023-08-24T14:14:04Z

shopfloor_reception/services/reception.py

@@ -1406,7 +1406,7 @@ def set_quantity(self):
            },
            "quantity": {"type": "float"},
            "barcode": {"type": "string"},
-            "confirmation": {"type": "boolean"},
+            "confirmation": {"type": "string"},


I think this should be now nullable

Suggested change

"confirmation": {"type": "string"},

"confirmation": {"type": "string", "required": False, "nullable": True},

cc @jbaudoux

I think so, yes.

I don't think this was required, but did the change anyway.

jbaudoux · 2023-09-26T08:53:44Z

@mt-software-de Can you provide a second approval on this one?

mt-software-de

LGTM

jbaudoux · 2023-11-21T15:21:12Z

/ocabot merge minor

OCA-git-bot · 2023-11-21T15:21:20Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-717-by-jbaudoux-bump-minor, awaiting test results.

Signed-off-by jbaudoux

OCA-git-bot · 2023-11-21T15:34:28Z

@jbaudoux your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-717-by-jbaudoux-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

jbaudoux · 2023-11-21T15:39:35Z

@TDu can you rebase?

TDu · 2023-11-22T07:46:24Z

@TDu can you rebase?

@jbaudoux Done

jbaudoux · 2023-11-22T08:10:30Z

@TDu Can you check failing test? Could not be related to this PR

mmequignon · 2023-11-22T09:09:51Z

@TDu Can you check failing test? Could not be related to this PR

https://github.com/OCA/wms/actions/runs/6954309475/job/18920884227?pr=717#step:8:3980

 2023-11-22 07:58:46,334 532 INFO odoo odoo.addons.shopfloor_reception_packaging_dimension.tests.test_set_package_dimension: ====================================================================== 
2023-11-22 07:58:46,334 532 ERROR odoo odoo.addons.shopfloor_reception_packaging_dimension.tests.test_set_package_dimension: FAIL: TestSetPackDimension.test_set_multiple_packaging_dimension
Traceback (most recent call last):
  File "/__w/wms/wms/shopfloor_reception_packaging_dimension/tests/test_set_package_dimension.py", line 159, in test_set_multiple_packaging_dimension
    self.product_c_packaging_2
  File "/__w/wms/wms/shopfloor_base/tests/common.py", line 204, in assert_response
    "\n\nExpected:\n%s" % (pformat(response), pformat(expected)),
AssertionError: {'data': {'set_quantity': {'selected_move_l[1094 chars]d.'}} != {'message': {'message_type': 'success', 'bo[1095 chars]se}}}
- {'data': {'set_quantity': {'confirmation_required': None,
?                                                     ^^^

+ {'data': {'set_quantity': {'confirmation_required': False,
?                                                     ^^^^

TDu · 2023-11-22T10:44:12Z

@jbaudoux Test fixed

OCA-git-bot · 2023-11-22T10:48:22Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

jbaudoux · 2023-11-22T10:49:29Z

/ocabot merge minor

OCA-git-bot · 2023-11-22T10:49:36Z

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-717-by-jbaudoux-bump-minor, awaiting test results.

OCA-git-bot · 2023-11-22T11:03:37Z

Congratulations, your PR was merged at 00708a2. Thanks a lot for contributing to OCA. ❤️

jbaudoux approved these changes Aug 21, 2023

View reviewed changes

simahawk reviewed Aug 21, 2023

View reviewed changes

mt-software-de reviewed Aug 24, 2023

View reviewed changes

TDu force-pushed the 14-shopfloor-reception-improve-confirmation branch from 3e8a284 to 34cc1c0 Compare August 30, 2023 09:32

mt-software-de approved these changes Nov 7, 2023

View reviewed changes

OCA-git-bot added the approved label Nov 7, 2023

OCA-git-bot added the bot is merging ⏳ label Nov 21, 2023

OCA-git-bot added a commit that referenced this pull request Nov 21, 2023

Merge PR #717 into 14.0

0da0896

Signed-off-by jbaudoux

OCA-git-bot removed the bot is merging ⏳ label Nov 21, 2023

TDu added 2 commits November 22, 2023 08:45

sf_reception: imp set_quantity confirmation

216f971

sf_reception_mobile: imp set_quantity confirmation

c2cec2d

TDu force-pushed the 14-shopfloor-reception-improve-confirmation branch from 34cc1c0 to c2cec2d Compare November 22, 2023 07:46

sf_reception_packaging_dimension: fix test confirmation

19e2877

OCA-git-bot added the ready to merge label Nov 22, 2023

OCA-git-bot added the bot is merging ⏳ label Nov 22, 2023

OCA-git-bot merged commit 61afa0a into OCA:14.0 Nov 22, 2023
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Nov 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0][IMP] shopfloor_reception improve confirmation #717

[14.0][IMP] shopfloor_reception improve confirmation #717

TDu commented Aug 10, 2023

OCA-git-bot commented Aug 10, 2023

simahawk Aug 21, 2023

TDu Aug 23, 2023

mt-software-de Aug 24, 2023

mt-software-de Aug 24, 2023

mmequignon Aug 25, 2023

TDu Aug 30, 2023

jbaudoux commented Sep 26, 2023

mt-software-de left a comment

jbaudoux commented Nov 21, 2023

OCA-git-bot commented Nov 21, 2023

OCA-git-bot commented Nov 21, 2023

jbaudoux commented Nov 21, 2023

TDu commented Nov 22, 2023

jbaudoux commented Nov 22, 2023

mmequignon commented Nov 22, 2023

TDu commented Nov 22, 2023

OCA-git-bot commented Nov 22, 2023

jbaudoux commented Nov 22, 2023

OCA-git-bot commented Nov 22, 2023

OCA-git-bot commented Nov 22, 2023

	"confirmation": {"type": "string"},
	"confirmation": {"type": "string", "required": False, "nullable": True},

[14.0][IMP] shopfloor_reception improve confirmation #717

[14.0][IMP] shopfloor_reception improve confirmation #717

Conversation

TDu commented Aug 10, 2023

OCA-git-bot commented Aug 10, 2023

simahawk Aug 21, 2023

Choose a reason for hiding this comment

TDu Aug 23, 2023

Choose a reason for hiding this comment

mt-software-de Aug 24, 2023

Choose a reason for hiding this comment

mt-software-de Aug 24, 2023

Choose a reason for hiding this comment

mmequignon Aug 25, 2023

Choose a reason for hiding this comment

TDu Aug 30, 2023

Choose a reason for hiding this comment

jbaudoux commented Sep 26, 2023

mt-software-de left a comment

Choose a reason for hiding this comment

jbaudoux commented Nov 21, 2023

OCA-git-bot commented Nov 21, 2023

OCA-git-bot commented Nov 21, 2023

jbaudoux commented Nov 21, 2023

TDu commented Nov 22, 2023

jbaudoux commented Nov 22, 2023

mmequignon commented Nov 22, 2023

TDu commented Nov 22, 2023

OCA-git-bot commented Nov 22, 2023

jbaudoux commented Nov 22, 2023

OCA-git-bot commented Nov 22, 2023

OCA-git-bot commented Nov 22, 2023