Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0] backport stock_release_channel_auto_release #566

Open
wants to merge 5 commits into
base: 14.0
Choose a base branch
from
Open

[14.0] backport stock_release_channel_auto_release #566

wants to merge 5 commits into from

Conversation

TDu
Copy link
Member

@TDu TDu commented Feb 9, 2023 •
edited by simahawk
Loading

@TDu TDu force-pushed the 14-stock_release_channel_auto_release branch from 00040d1 to 88e163b Compare February 9, 2023 14:08
@TDu TDu force-pushed the 14-stock_release_channel_auto_release branch 5 times, most recently from df75d9b to cb38676 Compare February 14, 2023 13:02
@TDu TDu changed the title [14.0] backport stock_release_channel_auto_release WIP DRAFT [14.0] backport stock_release_channel_auto_release Mar 6, 2023
@jbaudoux
Copy link
Contributor

@TDu Can you rebase now that the other one has been merged?

@TDu
Copy link
Member Author

TDu commented Mar 10, 2023

@jbaudoux This pr depends also on #595. Changes that were included here but needs to be in their own for review

@TDu TDu force-pushed the 14-stock_release_channel_auto_release branch 3 times, most recently from 3cbc3da to 7005bb7 Compare March 15, 2023 10:07
@TDu TDu force-pushed the 14-stock_release_channel_auto_release branch from 981e27d to 2851fbd Compare July 4, 2023 10:19
@TDu
Copy link
Member Author

TDu commented Jul 4, 2023

Rebased

@jbaudoux
Copy link
Contributor

jbaudoux commented Jul 4, 2023

@TDu Tests are failing

@TDu TDu force-pushed the 14-stock_release_channel_auto_release branch from 09b9bf1 to 2f3313e Compare July 6, 2023 10:08
@TDu TDu force-pushed the 14-stock_release_channel_auto_release branch from b0f0cb3 to f373741 Compare August 30, 2023 09:04
@TDu
Copy link
Member Author

TDu commented Aug 30, 2023

Rebased on 14.0

@TDu TDu force-pushed the 14-stock_release_channel_auto_release branch 3 times, most recently from 572a4ef to f6ec8db Compare October 10, 2023 14:51
@TDu TDu force-pushed the 14-stock_release_channel_auto_release branch from f6ec8db to 7801f64 Compare October 20, 2023 13:58
@TDu
Copy link
Member Author

TDu commented Oct 20, 2023

On this one I do not understand why the tests are failing.
What I can understand is Travis is running the tests at install although I am using
@tagged("post_install", "-at_install")
I tried the same decorator on the actual test files as well (see before my force push)

Tests seem to be failing because a default value from an odoo module sale_stock I think is not being set !
We had the same problem before but the default value was meant to come from an OCA module, so it was refactored, to help with this issue among other things.

@grindtildeath grindtildeath force-pushed the 14-stock_release_channel_auto_release branch from 4770aee to b7e3b9e Compare October 24, 2023 14:54
@grindtildeath
Copy link
Contributor

@TDu tests execution must be fixed but there's a dependency issue related to development status.
Should be fixed when this PR will be merged: OCA/stock-logistics-workflow#1409

@grindtildeath grindtildeath force-pushed the 14-stock_release_channel_auto_release branch from b7e3b9e to 2c715c7 Compare October 30, 2023 11:07
@grindtildeath
Copy link
Contributor

I thought moving the decorator from the common class to the actual test classes did solve the issues as I was then unable to reproduce it locally anymore.

However, last CI run is still failing because the setUpClass function creates a product while sale module is not loaded.
I'm unable to reproduce this locally, because the test class are now well decorated with -at_install and this function evaluates to False: https://github.com/odoo/odoo/blob/14.0/odoo/modules/loading.py#L258
(make_suite is supposed to filter out tests that must not be run at install, according to the decorator, but somehow they are executed in the CI and there's no visible log to understand why)

Considering the following log appearing in the CI: odoo odoo.modules.loading: Module stock_available_to_promise_release loaded in 3.12s (incl. 1.13s test), 716 queries (+976 test), my deduction is the suite.countTestCases() condition evaluates to True.

There must be something wrong in the building of the test suite, but without being able to reproduce or access the failing server, I'm not sure we can do much.

mt-software-de
mt-software-de suggested changes Jan 16, 2024
View reviewed changes
stock_release_channel/models/stock_release_channel.py Outdated

def _get_pickings_to_release(self):
"""Get the pickings to release."""
domain = self._field_picking_domains()["count_picking_release_ready"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
domain = self._field_picking_domains()["count_picking_release_ready"]
domain = self._field_picking_domains()["release_ready"]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TDu Can you do this simple change and rebase ?

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 19, 2024
lmignon and others added 5 commits May 22, 2024 10:15
@lmignon @TDu
[ADD] stock_release_channel_auto_release: Add automatic release mode
4cec3b8 
This addons define an automatic release mode on the release channels. By default
release channels manage the release of the transfers in batch mode. This means
that the transfers are released only when the user manually triggers the release
process by clicking on the release button.

When the automatic release mode is enabled, the transfers are released automatically
when a new transfer is added to the channel or as soon a product becomes available.

As for the batch mode, the automatic release process is only active on open channels.
When is locked, the automatic release process is stopped. Once the channel is unlocked,
the automatic release process is restarted and transfers into the channel are released
if they are ready to be released (IOW if quantities are available for moves not
yet released).
@TDu
Fix stock_release_channel_auto_release backward port to 14
28292d5
@grindtildeath @TDu
Fix execution of tests post install
22ad3d1
@grindtildeath @TDu
fixup! Fix execution of tests post install
b27081d
@TDu
fixup! [ADD] stock_release_channel_auto_release: Add automatic releas…
184f64a 
…e mode
@TDu TDu force-pushed the 14-stock_release_channel_auto_release branch from d235b2f to 184f64a Compare May 22, 2024 08:25
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 26, 2024
@mt-software-de mt-software-de mentioned this pull request Jul 30, 2024
Merged
@mt-software-de
Copy link
Contributor

I just finished OCA/stock-logistics-warehouse#2122
This moves the _delay_auto_release_available_to_promise method into the addon stock_move_auto_assign_auto_release

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbaudoux jbaudoux jbaudoux requested changes

@mt-software-de mt-software-de mt-software-de requested changes

Assignees
No one assigned
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TDu @jbaudoux @grindtildeath @mt-software-de @lmignon